Commit 7d8e8f34 authored Jul 29, 2020 by Ido Schimmel Committed by David S. Miller Jul 29, 2020

mlxsw: core: Increase scope of RCU read-side critical section



The lifetime of the Rx listener item ('rxl_item') is managed using RCU,
but is dereferenced outside of RCU read-side critical section, which can
lead to a use-after-free.

Fix this by increasing the scope of the RCU read-side critical section.

Fixes: 93c1edb2 ("mlxsw: Introduce Mellanox switch driver core")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ec4f5b36

drivers/net/ethernet/mellanox/mlxsw/core.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2051,11 +2051,13 @@ void mlxsw_core_skb_receive(struct mlxsw_core mlxsw_core, struct sk_buff skb,
		break;
		}
		}
		if (!found) {
		rcu_read_unlock();
		if (!found)
		goto drop;
		}

		rxl->func(skb, local_port, rxl_item->priv);
		rcu_read_unlock();
		return;

		drop:

Admin message