Commit 7d821274 authored Oct 31, 2019 by David Hildenbrand Committed by Michael Ellerman Nov 13, 2019

powerpc/pseries/cmm: Implement release() function for sysfs device



When unloading the module, one gets
  ------------[ cut here ]------------
  Device 'cmm0' does not have a release() function, it is broken and must be fixed. See Documentation/kobject.txt.
  WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .device_release+0xcc/0xf0
  ...

We only have one static fake device. There is nothing to do when
releasing the device (via cmm_exit()).

Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191031142933.10779-2-david@redhat.com

parent 0a87ccd3

arch/powerpc/platforms/pseries/cmm.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -411,6 +411,10 @@ static struct bus_type cmm_subsys = {
		.dev_name = "cmm",
		};

		static void cmm_release_device(struct device *dev)
		{
		}

		/**
		* cmm_sysfs_register - Register with sysfs
		*
		@@ -426,6 +430,7 @@ static int cmm_sysfs_register(struct device *dev)

		dev->id = 0;
		dev->bus = &cmm_subsys;
		dev->release = cmm_release_device;

		if ((rc = device_register(dev)))
		goto subsys_unregister;

Admin message