Commit 7d734532 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: fix warning in ext4_da_update_reserve_space() 



reaim workfile.dbase test easily triggers warning in
ext4_da_update_reserve_space():

EXT4-fs warning (device ram0): ext4_da_update_reserve_space:365:
ino 12, allocated 1 with only 0 reserved metadata blocks (releasing 1
blocks with reserved 9 data blocks)

The problem is that (one of) tests creates file and then randomly writes
to it with O_SYNC. That results in writing back pages of the file in
random order so we create extents for written blocks say 0, 2, 4, 6, 8
- this last allocation also allocates new block for extents. Then we
writeout block 1 so we have extents 0-2, 4, 6, 8 and we release
indirect extent block because extents fit in the inode again. Then we
writeout block 10 and we need to allocate indirect extent block again
which triggers the warning because we don't have the reservation
anymore.

Fix the problem by giving back freed metadata blocks resulting from
extent merging into inode's reservation pool.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 1c8924eb

fs/ext4/ext4.h

+1 −0
Original line number Diff line number Diff line
@@ -581,6 +581,7 @@ enum { 
#define EXT4_FREE_BLOCKS_NO_QUOT_UPDATE	0x0008

#define EXT4_FREE_BLOCKS_NOFREE_FIRST_CLUSTER	0x0010

#define EXT4_FREE_BLOCKS_NOFREE_LAST_CLUSTER	0x0020

#define EXT4_FREE_BLOCKS_RESERVE		0x0040



/*

 * ioctl commands

fs/ext4/extents.c

+2 −1
Original line number Diff line number Diff line
@@ -1793,7 +1793,8 @@ static void ext4_ext_try_to_merge_up(handle_t *handle, 


	brelse(path[1].p_bh);

	ext4_free_blocks(handle, inode, NULL, blk, 1,

			 EXT4_FREE_BLOCKS_METADATA | EXT4_FREE_BLOCKS_FORGET);

			 EXT4_FREE_BLOCKS_METADATA | EXT4_FREE_BLOCKS_FORGET |

			 EXT4_FREE_BLOCKS_RESERVE);

}



/*

fs/ext4/mballoc.c

+17 −4
Original line number Diff line number Diff line
@@ -4585,6 +4585,7 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, 
	struct buffer_head *gd_bh;

	ext4_group_t block_group;

	struct ext4_sb_info *sbi;

	struct ext4_inode_info *ei = EXT4_I(inode);

	struct ext4_buddy e4b;

	unsigned int count_clusters;

	int err = 0;
@@ -4784,7 +4785,6 @@ do_more: 
	ext4_block_bitmap_csum_set(sb, block_group, gdp, bitmap_bh);

	ext4_group_desc_csum_set(sb, block_group, gdp);

	ext4_unlock_group(sb, block_group);

	percpu_counter_add(&sbi->s_freeclusters_counter, count_clusters);



	if (sbi->s_log_groups_per_flex) {

		ext4_group_t flex_group = ext4_flex_group(sbi, block_group);
@@ -4792,10 +4792,23 @@ do_more: 
			     &sbi->s_flex_groups[flex_group].free_clusters);

	}



	ext4_mb_unload_buddy(&e4b);



	if (flags & EXT4_FREE_BLOCKS_RESERVE && ei->i_reserved_data_blocks) {

		percpu_counter_add(&sbi->s_dirtyclusters_counter,

				   count_clusters);

		spin_lock(&ei->i_block_reservation_lock);

		if (flags & EXT4_FREE_BLOCKS_METADATA)

			ei->i_reserved_meta_blocks += count_clusters;

		else

			ei->i_reserved_data_blocks += count_clusters;

		spin_unlock(&ei->i_block_reservation_lock);

		if (!(flags & EXT4_FREE_BLOCKS_NO_QUOT_UPDATE))

			dquot_reclaim_block(inode,

					EXT4_C2B(sbi, count_clusters));

	} else if (!(flags & EXT4_FREE_BLOCKS_NO_QUOT_UPDATE))

		dquot_free_block(inode, EXT4_C2B(sbi, count_clusters));

	percpu_counter_add(&sbi->s_freeclusters_counter, count_clusters);



	ext4_mb_unload_buddy(&e4b);



	/* We dirtied the bitmap block */

	BUFFER_TRACE(bitmap_bh, "dirtied bitmap block");

CRA Git | Maintained and supported by SUSTech CRA and CCSE