Commit 7d731019 authored Feb 01, 2012 by Artem Bityutskiy Committed by Linus Torvalds Feb 01, 2012

mtd: fix merge conflict resolution breakage

This patch fixes merge conflict resolution breakage introduced by merge
d3712b9d ("Merge tag 'for-linus' of git://github.com/prasad-joshi/logfs_upstream"

).

The commit changed 'mtd_can_have_bb()' function and made it always
return zero, which is incorrect.  Instead, we need it to return whether
the underlying flash device can have bad eraseblocks or not.  UBI needs
this information because it affects how it handles the underlying flash.
E.g., if the underlying flash is NOR, it cannot have bad blocks and any
write or erase error is fatal, and all we can do is to switch to R/O
mode.  We do not need to reserve a pool of good eraseblocks for bad
eraseblocks handling, and so on.

This patch also removes 'mtd_can_have_bb()' invocations from Logfs to
ensure correct Logfs behavior.

I've tested that with this patch UBI works on top of NOR and NAND
flashes emulated by mtdram and nandsim correspondingly.

This patch is based on patch from Linus Torvalds.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Acked-by: Jörn Engel <joern@logfs.org>
Acked-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
Acked-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 62aa2b53

fs/logfs/dev_mtd.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -152,9 +152,6 @@ static struct page logfs_mtd_find_first_sb(struct super_block sb, u64 *ofs)
		filler_t *filler = logfs_mtd_readpage;
		struct mtd_info *mtd = super->s_mtd;

		if (!mtd_can_have_bb(mtd))
		return NULL;

		*ofs = 0;
		while (mtd_block_isbad(mtd, *ofs)) {
		*ofs += mtd->erasesize;
		@@ -172,9 +169,6 @@ static struct page logfs_mtd_find_last_sb(struct super_block sb, u64 *ofs)
		filler_t *filler = logfs_mtd_readpage;
		struct mtd_info *mtd = super->s_mtd;

		if (!mtd_can_have_bb(mtd))
		return NULL;

		*ofs = mtd->size - mtd->erasesize;
		while (mtd_block_isbad(mtd, *ofs)) {
		*ofs -= mtd->erasesize;

include/linux/mtd/mtd.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -489,7 +489,7 @@ static inline int mtd_has_oob(const struct mtd_info *mtd)

		static inline int mtd_can_have_bb(const struct mtd_info *mtd)
		{
		return 0;
		return !!mtd->block_isbad;
		}

		/* Kernel-side ioctl definitions */

Admin message