Commit 7d66a714 authored Oct 26, 2020 by Gal Pressman Committed by Jason Gunthorpe Oct 26, 2020

RDMA/uverbs: Fix false error in query gid IOCTL

Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices.
Remove the unnecessary rdma_ib_or_roce() check.

This fixes rdma-core failures for EFA when it uses the new ioctl interface
for querying the GID table.

Fixes: 9f85cbe5 ("RDMA/uverbs: Expose the new GID query API to user space")
Link: https://lore.kernel.org/r/20201026082621.32463-1-galpress@amazon.com


Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent fbdd0049

drivers/infiniband/core/uverbs_std_types_device.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -401,9 +401,6 @@ static int UVERBS_HANDLER(UVERBS_METHOD_QUERY_GID_ENTRY)(
		if (!rdma_is_port_valid(ib_dev, port_num))
		return -EINVAL;

		if (!rdma_ib_or_roce(ib_dev, port_num))
		return -EOPNOTSUPP;

		gid_attr = rdma_get_gid_attr(ib_dev, port_num, gid_index);
		if (IS_ERR(gid_attr))
		return PTR_ERR(gid_attr);

Admin message