Commit 7d64f82c authored Mar 16, 2017 by James Morse Committed by Rafael J. Wysocki Mar 28, 2017

ACPI / APEI: Add missing synchronize_rcu() on NOTIFY_SCI removal

When removing a GHES device notified by SCI, list_del_rcu() is used,
ghes_remove() should call synchronize_rcu() before it goes on to call
kfree(ghes), otherwise concurrent RCU readers may still hold this list
entry after it has been freed.

Signed-off-by: James Morse <james.morse@arm.com>
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Fixes: 81e88fdc (ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent c02ed2e7

drivers/acpi/apei/ghes.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1073,6 +1073,7 @@ static int ghes_remove(struct platform_device *ghes_dev)
		if (list_empty(&ghes_sci))
		unregister_acpi_hed_notifier(&ghes_notifier_sci);
		mutex_unlock(&ghes_list_mutex);
		synchronize_rcu();
		break;
		case ACPI_HEST_NOTIFY_NMI:
		ghes_nmi_remove(ghes);

Admin message