Commit 7d554902 authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Jason Cooper
Browse files

arm: mach-dove: convert to use mvebu-mbus driver 



This commit migrates the mach-dove platforms to use the mvebu-mbus
driver and therefore removes the Dove-specific addr-map code.

The dove_init_early() function now initializes the mvebu-mbus driver
by calling mvebu_mbus_init().

The address decoding windows are now registered in the
dove_setup_cpu_wins() function. It is worth noting that the four PCIe
address decoding windows will ultimately no longer have to be
registered here: it will be done automatically by the PCIe driver once
Dove has been migrated to use the upcoming mvebu PCIe driver.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent 5cc0673a

arch/arm/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -562,6 +562,7 @@ config ARCH_DOVE 
	select PINCTRL_DOVE

	select PLAT_ORION_LEGACY

	select USB_ARCH_HAS_EHCI

	select MVEBU_MBUS

	help

	  Support for the Marvell Dove SoC 88AP510

arch/arm/mach-dove/Makefile

+1 −1
Original line number Diff line number Diff line 
obj-y				+= common.o addr-map.o irq.o

obj-y				+= common.o irq.o

obj-$(CONFIG_DOVE_LEGACY)	+= mpp.o

obj-$(CONFIG_PCI)		+= pcie.o

obj-$(CONFIG_MACH_DOVE_DB)	+= dove-db-setup.o

arch/arm/mach-dove/addr-map.c

deleted100644 → 0
+0 −125
Original line number Diff line number Diff line 
/*

 * arch/arm/mach-dove/addr-map.c

 *

 * Address map functions for Marvell Dove 88AP510 SoC

 *

 * This file is licensed under the terms of the GNU General Public

 * License version 2.  This program is licensed "as is" without any

 * warranty of any kind, whether express or implied.

 */



#include <linux/kernel.h>

#include <linux/init.h>

#include <linux/mbus.h>

#include <linux/io.h>

#include <asm/mach/arch.h>

#include <asm/setup.h>

#include <mach/dove.h>

#include <plat/addr-map.h>

#include "common.h"



/*

 * Generic Address Decode Windows bit settings

 */

#define TARGET_DDR		0x0

#define TARGET_BOOTROM		0x1

#define TARGET_CESA		0x3

#define TARGET_PCIE0		0x4

#define TARGET_PCIE1		0x8

#define TARGET_SCRATCHPAD	0xd



#define ATTR_CESA		0x01

#define ATTR_BOOTROM		0xfd

#define ATTR_DEV_SPI0_ROM	0xfe

#define ATTR_DEV_SPI1_ROM	0xfb

#define ATTR_PCIE_IO		0xe0

#define ATTR_PCIE_MEM		0xe8

#define ATTR_SCRATCHPAD		0x0



static inline void __iomem *ddr_map_sc(int i)

{

	return (void __iomem *)(DOVE_MC_VIRT_BASE + 0x100 + ((i) << 4));

}



/*

 * Description of the windows needed by the platform code

 */

static struct __initdata orion_addr_map_cfg addr_map_cfg = {

	.num_wins = 8,

	.remappable_wins = 4,

	.bridge_virt_base = BRIDGE_VIRT_BASE,

};



static const struct __initdata orion_addr_map_info addr_map_info[] = {

	/*

	 * Windows for PCIe IO+MEM space.

	 */

	{ 0, DOVE_PCIE0_IO_PHYS_BASE, DOVE_PCIE0_IO_SIZE,

	  TARGET_PCIE0, ATTR_PCIE_IO, DOVE_PCIE0_IO_BUS_BASE

	},

	{ 1, DOVE_PCIE1_IO_PHYS_BASE, DOVE_PCIE1_IO_SIZE,

	  TARGET_PCIE1, ATTR_PCIE_IO, DOVE_PCIE1_IO_BUS_BASE

	},

	{ 2, DOVE_PCIE0_MEM_PHYS_BASE, DOVE_PCIE0_MEM_SIZE,

	  TARGET_PCIE0, ATTR_PCIE_MEM, -1

	},

	{ 3, DOVE_PCIE1_MEM_PHYS_BASE, DOVE_PCIE1_MEM_SIZE,

	  TARGET_PCIE1, ATTR_PCIE_MEM, -1

	},

	/*

	 * Window for CESA engine.

	 */

	{ 4, DOVE_CESA_PHYS_BASE, DOVE_CESA_SIZE,

	  TARGET_CESA, ATTR_CESA, -1

	},

	/*

	 * Window to the BootROM for Standby and Sleep Resume

	 */

	{ 5, DOVE_BOOTROM_PHYS_BASE, DOVE_BOOTROM_SIZE,

	  TARGET_BOOTROM, ATTR_BOOTROM, -1

	},

	/*

	 * Window to the PMU Scratch Pad space

	 */

	{ 6, DOVE_SCRATCHPAD_PHYS_BASE, DOVE_SCRATCHPAD_SIZE,

	  TARGET_SCRATCHPAD, ATTR_SCRATCHPAD, -1

	},

	/* End marker */

	{ -1, 0, 0, 0, 0, 0 }

};



void __init dove_setup_cpu_mbus(void)

{

	int i;

	int cs;



	/*

	 * Disable, clear and configure windows.

	 */

	orion_config_wins(&addr_map_cfg, addr_map_info);



	/*

	 * Setup MBUS dram target info.

	 */

	orion_mbus_dram_info.mbus_dram_target_id = TARGET_DDR;



	for (i = 0, cs = 0; i < 2; i++) {

		u32 map = readl(ddr_map_sc(i));



		/*

		 * Chip select enabled?

		 */

		if (map & 1) {

			struct mbus_dram_window *w;



			w = &orion_mbus_dram_info.cs[cs++];

			w->cs_index = i;

			w->mbus_attr = 0; /* CS address decoding done inside */

					  /* the DDR controller, no need to  */

					  /* provide attributes */

			w->base = map & 0xff800000;

			w->size = 0x100000 << (((map & 0x000f0000) >> 16) - 4);

		}

	}

	orion_mbus_dram_info.num_cs = cs;

}

arch/arm/mach-dove/board-dt.c

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ static void __init dove_dt_init(void) 
#ifdef CONFIG_CACHE_TAUROS2

	tauros2_init(0);

#endif

	dove_setup_cpu_mbus();

	dove_setup_cpu_wins();



	/* Setup root of clk tree */

	dove_of_clk_init();

arch/arm/mach-dove/common.c

+38 −1
Original line number Diff line number Diff line
@@ -224,6 +224,9 @@ void __init dove_i2c_init(void) 
void __init dove_init_early(void)

{

	orion_time_set_base(TIMER_VIRT_BASE);

	mvebu_mbus_init("marvell,dove-mbus",

			BRIDGE_WINS_BASE, BRIDGE_WINS_SZ,

			DOVE_MC_WINS_BASE, DOVE_MC_WINS_SZ);

}



static int __init dove_find_tclk(void)
@@ -326,6 +329,40 @@ void __init dove_sdio1_init(void) 
	platform_device_register(&dove_sdio1);

}



void __init dove_setup_cpu_wins(void)

{

	/*

	 * The PCIe windows will no longer be statically allocated

	 * here once Dove is migrated to the pci-mvebu driver.

	 */

	mvebu_mbus_add_window_remap_flags("pcie0.0",

					  DOVE_PCIE0_IO_PHYS_BASE,

					  DOVE_PCIE0_IO_SIZE,

					  DOVE_PCIE0_IO_BUS_BASE,

					  MVEBU_MBUS_PCI_IO);

	mvebu_mbus_add_window_remap_flags("pcie1.0",

					  DOVE_PCIE1_IO_PHYS_BASE,

					  DOVE_PCIE1_IO_SIZE,

					  DOVE_PCIE1_IO_BUS_BASE,

					  MVEBU_MBUS_PCI_IO);

	mvebu_mbus_add_window_remap_flags("pcie0.0",

					  DOVE_PCIE0_MEM_PHYS_BASE,

					  DOVE_PCIE0_MEM_SIZE,

					  MVEBU_MBUS_NO_REMAP,

					  MVEBU_MBUS_PCI_MEM);

	mvebu_mbus_add_window_remap_flags("pcie1.0",

					  DOVE_PCIE1_MEM_PHYS_BASE,

					  DOVE_PCIE1_MEM_SIZE,

					  MVEBU_MBUS_NO_REMAP,

					  MVEBU_MBUS_PCI_MEM);

	mvebu_mbus_add_window("cesa", DOVE_CESA_PHYS_BASE,

			      DOVE_CESA_SIZE);

	mvebu_mbus_add_window("bootrom", DOVE_BOOTROM_PHYS_BASE,

			      DOVE_BOOTROM_SIZE);

	mvebu_mbus_add_window("scratchpad", DOVE_SCRATCHPAD_PHYS_BASE,

			      DOVE_SCRATCHPAD_SIZE);

}



void __init dove_init(void)

{

	pr_info("Dove 88AP510 SoC, TCLK = %d MHz.\n",
@@ -334,7 +371,7 @@ void __init dove_init(void) 
#ifdef CONFIG_CACHE_TAUROS2

	tauros2_init(0);

#endif

	dove_setup_cpu_mbus();

	dove_setup_cpu_wins();



	/* Setup root of clk tree */

	dove_clk_init();

CRA Git | Maintained and supported by SUSTech CRA and CCSE