Commit 7d3615ae authored Nov 30, 2020 by Damien Le Moal Committed by Bartosz Golaszewski Nov 30, 2020

gpio: dwapb: Remove unnecessary error message



In dwapb_get_reset(), if devm_reset_control_get_optional_shared() fails,
an error message is printed even if the failure is the benign
EPROBE_DEFER error due to the reset controller not yet being
initialized. Use dev_err_probe() to handle
devm_reset_control_get_optional_shared() errors to avoid unnecessarilly
printing an error message for the deferred probe error.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 5300ebb6

drivers/gpio/gpio-dwapb.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -616,10 +616,9 @@ static int dwapb_get_reset(struct dwapb_gpio *gpio)
		int err;

		gpio->rst = devm_reset_control_get_optional_shared(gpio->dev, NULL);
		if (IS_ERR(gpio->rst)) {
		dev_err(gpio->dev, "Cannot get reset descriptor\n");
		return PTR_ERR(gpio->rst);
		}
		if (IS_ERR(gpio->rst))
		return dev_err_probe(gpio->dev, PTR_ERR(gpio->rst),
		"Cannot get reset descriptor\n");

		err = reset_control_deassert(gpio->rst);
		if (err) {

Admin message