Commit 7d1a5efa authored Aug 07, 2019 by Arnaldo Carvalho de Melo

perf hists: Do not link a pair if already linked

When we have multiple events in a group we link hist_entries in the
non-leader evsel hists to the one in the leader that points to the same
sorting criteria, in hists__match().

For 'perf report' we do this just once and then print the results, but
for 'perf top' we need to look if this was already done in the previous
refresh of the screen, so check for that and don't try to link again.

This is part of having 'perf top' using the hists browser for showing
multiple events in multiple columns.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-iwvb37rgb7upswhruwpcdnhw@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 1205a271

tools/perf/util/hist.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2453,7 +2453,7 @@ void hists__match(struct hists leader, struct hists other)
		pos = rb_entry(nd, struct hist_entry, rb_node_in);
		pair = hists__find_entry(other, pos);

		if (pair)
		if (pair && list_empty(&pair->pairs.node))
		hist_entry__add_pair(pair, pos);
		}
		}

Admin message