Commit 7d060ed2 authored by Tilman Schmidt's avatar Tilman Schmidt Committed by David S. Miller
Browse files

isdn/gigaset: reduce syslog spam



Downgrade some error messages which occur frequently during
normal operation to debug messages.

Impact: logging
Signed-off-by: default avatarTilman Schmidt <tilman@imap.cc>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0cae6efd
Loading
Loading
Loading
Loading
+8 −8
Original line number Diff line number Diff line
@@ -383,13 +383,13 @@ void gigaset_skb_sent(struct bc_state *bcs, struct sk_buff *dskb)
	++bcs->trans_up;

	if (!ap) {
		dev_err(cs->dev, "%s: no application\n", __func__);
		gig_dbg(DEBUG_MCMD, "%s: application gone", __func__);
		return;
	}

	/* don't send further B3 messages if disconnected */
	if (bcs->apconnstate < APCONN_ACTIVE) {
		gig_dbg(DEBUG_MCMD, "disconnected, discarding ack");
		gig_dbg(DEBUG_MCMD, "%s: disconnected", __func__);
		return;
	}

@@ -427,13 +427,14 @@ void gigaset_skb_rcvd(struct bc_state *bcs, struct sk_buff *skb)
	bcs->trans_down++;

	if (!ap) {
		dev_err(cs->dev, "%s: no application\n", __func__);
		gig_dbg(DEBUG_MCMD, "%s: application gone", __func__);
		dev_kfree_skb_any(skb);
		return;
	}

	/* don't send further B3 messages if disconnected */
	if (bcs->apconnstate < APCONN_ACTIVE) {
		gig_dbg(DEBUG_MCMD, "disconnected, discarding data");
		gig_dbg(DEBUG_MCMD, "%s: disconnected", __func__);
		dev_kfree_skb_any(skb);
		return;
	}
@@ -752,7 +753,7 @@ void gigaset_isdn_connD(struct bc_state *bcs)
	ap = bcs->ap;
	if (!ap) {
		spin_unlock_irqrestore(&bcs->aplock, flags);
		dev_err(cs->dev, "%s: no application\n", __func__);
		gig_dbg(DEBUG_CMD, "%s: application gone", __func__);
		return;
	}
	if (bcs->apconnstate == APCONN_NONE) {
@@ -848,7 +849,7 @@ void gigaset_isdn_connB(struct bc_state *bcs)
	ap = bcs->ap;
	if (!ap) {
		spin_unlock_irqrestore(&bcs->aplock, flags);
		dev_err(cs->dev, "%s: no application\n", __func__);
		gig_dbg(DEBUG_CMD, "%s: application gone", __func__);
		return;
	}
	if (!bcs->apconnstate) {
@@ -906,13 +907,12 @@ void gigaset_isdn_connB(struct bc_state *bcs)
 */
void gigaset_isdn_hupB(struct bc_state *bcs)
{
	struct cardstate *cs = bcs->cs;
	struct gigaset_capi_appl *ap = bcs->ap;

	/* ToDo: assure order of DISCONNECT_B3_IND and DISCONNECT_IND ? */

	if (!ap) {
		dev_err(cs->dev, "%s: no application\n", __func__);
		gig_dbg(DEBUG_CMD, "%s: application gone", __func__);
		return;
	}