Commit 7cff4b18 authored Mar 16, 2015 by NeilBrown Committed by Greg Kroah-Hartman Mar 16, 2015

kernfs: handle poll correctly on 'direct_read' files.



Kernfs supports two styles of read: direct_read and seqfile_read.

The latter supports 'poll' correctly thanks to the update of
'->event' in kernfs_seq_show.
The former does not as '->event' is never updated on a read.

So add an appropriate update in kernfs_file_direct_read().

This was noticed because some 'md' sysfs attributes were
recently changed to use direct reads.

Reported-by: Prakash Punnoor <prakash@punnoor.de>
Reported-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Fixes: 750f199e
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 06e5801b

fs/kernfs/file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -207,6 +207,7 @@ static ssize_t kernfs_file_direct_read(struct kernfs_open_file *of,
		goto out_free;
		}

		of->event = atomic_read(&of->kn->attr.open->event);
		ops = kernfs_ops(of->kn);
		if (ops->read)
		len = ops->read(of, buf, len, *ppos);

Admin message