Commit 7cf4eda4 authored May 27, 2020 by Colin Ian King Committed by David S. Miller May 27, 2020

mlxsw: spectrum_router: remove redundant initialization of pointer br_dev



The pointer br_dev is being initialized with a value that is never read
and is being updated with a new value later on. The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d8e79f1d

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7574,7 +7574,7 @@ static struct mlxsw_sp_fid *
		mlxsw_sp_rif_vlan_fid_get(struct mlxsw_sp_rif *rif,
		struct netlink_ext_ack *extack)
		{
		struct net_device *br_dev = rif->dev;
		struct net_device *br_dev;
		u16 vid;
		int err;

Admin message