Commit 7ceeb6a4 authored Apr 02, 2009 by Uwe Kleine-König Committed by Pierre Ossman Jun 13, 2009

mmc/omap: make mmci-omap using platform_driver_probe



A pointer to mmc_omap_probe which lives in .init.text is passed to the
core via platform_driver_register and so the kernel might oops if probe
is called after the init code is discarded.

As requested by David Brownell platform_driver_probe is used instead of
moving the probe function to .devinit.text.  This saves some memory, but
might have the downside that a device being registered after the call to
mmc_omap_init but before the init sections are discarded will not be
bound anymore to the driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Pierre Ossman <pierre@ossman.eu>

parent 5cf20aa5

drivers/mmc/host/omap.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1593,7 +1593,6 @@ static int mmc_omap_resume(struct platform_device *pdev)
		#endif

		static struct platform_driver mmc_omap_driver = {
		.probe = mmc_omap_probe,
		.remove = mmc_omap_remove,
		.suspend = mmc_omap_suspend,
		.resume = mmc_omap_resume,
		@@ -1605,7 +1604,7 @@ static struct platform_driver mmc_omap_driver = {

		static int __init mmc_omap_init(void)
		{
		return platform_driver_register(&mmc_omap_driver);
		return platform_driver_probe(&mmc_omap_driver, mmc_omap_probe);
		}

		static void __exit mmc_omap_exit(void)

Admin message