Commit 7cd12b4a authored by Vlastimil Babka's avatar Vlastimil Babka Committed by Linus Torvalds
Browse files

mm, page_owner: track and print last migrate reason 



During migration, page_owner info is now copied with the rest of the
page, so the stacktrace leading to free page allocation during migration
is overwritten.  For debugging purposes, it might be however useful to
know that the page has been migrated since its initial allocation.  This
might happen many times during the lifetime for different reasons and
fully tracking this, especially with stacktraces would incur extra
memory costs.  As a compromise, store and print the migrate_reason of
the last migration that occurred to the page.  This is enough to
distinguish compaction, numa balancing etc.

Example page_owner entry after the patch:

  Page allocated via order 0, mask 0x24200ca(GFP_HIGHUSER_MOVABLE)
  PFN 628753 type Movable Block 1228 type Movable Flags 0x1fffff80040030(dirty|lru|swapbacked)
   [<ffffffff811682c4>] __alloc_pages_nodemask+0x134/0x230
   [<ffffffff811b6325>] alloc_pages_vma+0xb5/0x250
   [<ffffffff81177491>] shmem_alloc_page+0x61/0x90
   [<ffffffff8117a438>] shmem_getpage_gfp+0x678/0x960
   [<ffffffff8117c2b9>] shmem_fallocate+0x329/0x440
   [<ffffffff811de600>] vfs_fallocate+0x140/0x230
   [<ffffffff811df434>] SyS_fallocate+0x44/0x70
   [<ffffffff8158cc2e>] entry_SYSCALL_64_fastpath+0x12/0x71
  Page has been migrated, last migrate reason: compaction

Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sasha Levin <sasha.levin@oracle.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d435edca

include/linux/migrate.h

+5 −1
Original line number Original line Diff line number Diff line
@@ -23,9 +23,13 @@ enum migrate_reason { 
	MR_SYSCALL,		/* also applies to cpusets */

	MR_SYSCALL,		/* also applies to cpusets */

	MR_MEMPOLICY_MBIND,

	MR_MEMPOLICY_MBIND,

	MR_NUMA_MISPLACED,

	MR_NUMA_MISPLACED,

	MR_CMA

	MR_CMA,

	MR_TYPES

};

};





/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */

extern char *migrate_reason_names[MR_TYPES];



#ifdef CONFIG_MIGRATION

#ifdef CONFIG_MIGRATION





extern void putback_movable_pages(struct list_head *l);

extern void putback_movable_pages(struct list_head *l);

include/linux/page_ext.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -45,6 +45,7 @@ struct page_ext { 
	unsigned int order;

	unsigned int order;

	gfp_t gfp_mask;

	gfp_t gfp_mask;

	unsigned int nr_entries;

	unsigned int nr_entries;

	int last_migrate_reason;

	unsigned long trace_entries[8];

	unsigned long trace_entries[8];

#endif

#endif

};

};

include/linux/page_owner.h

+9 −0
Original line number Original line Diff line number Diff line
@@ -12,6 +12,7 @@ extern void __set_page_owner(struct page *page, 
			unsigned int order, gfp_t gfp_mask);

			unsigned int order, gfp_t gfp_mask);

extern gfp_t __get_page_owner_gfp(struct page *page);

extern gfp_t __get_page_owner_gfp(struct page *page);

extern void __copy_page_owner(struct page *oldpage, struct page *newpage);

extern void __copy_page_owner(struct page *oldpage, struct page *newpage);

extern void __set_page_owner_migrate_reason(struct page *page, int reason);





static inline void reset_page_owner(struct page *page, unsigned int order)

static inline void reset_page_owner(struct page *page, unsigned int order)

{

{
@@ -38,6 +39,11 @@ static inline void copy_page_owner(struct page *oldpage, struct page *newpage) 
	if (static_branch_unlikely(&page_owner_inited))

	if (static_branch_unlikely(&page_owner_inited))

		__copy_page_owner(oldpage, newpage);

		__copy_page_owner(oldpage, newpage);

}

}

static inline void set_page_owner_migrate_reason(struct page *page, int reason)

{

	if (static_branch_unlikely(&page_owner_inited))

		__set_page_owner_migrate_reason(page, reason);

}

#else

#else

static inline void reset_page_owner(struct page *page, unsigned int order)

static inline void reset_page_owner(struct page *page, unsigned int order)

{

{
@@ -53,5 +59,8 @@ static inline gfp_t get_page_owner_gfp(struct page *page) 
static inline void copy_page_owner(struct page *oldpage, struct page *newpage)

static inline void copy_page_owner(struct page *oldpage, struct page *newpage)

{

{

}

}

static inline void set_page_owner_migrate_reason(struct page *page, int reason)

{

}

#endif /* CONFIG_PAGE_OWNER */

#endif /* CONFIG_PAGE_OWNER */

#endif /* __LINUX_PAGE_OWNER_H */
 
#endif /* __LINUX_PAGE_OWNER_H */

mm/debug.c

+11 −0
Original line number Original line Diff line number Diff line
@@ -10,9 +10,20 @@ 
#include <linux/trace_events.h>

#include <linux/trace_events.h>

#include <linux/memcontrol.h>

#include <linux/memcontrol.h>

#include <trace/events/mmflags.h>

#include <trace/events/mmflags.h>

#include <linux/migrate.h>





#include "internal.h"

#include "internal.h"





char *migrate_reason_names[MR_TYPES] = {

	"compaction",

	"memory_failure",

	"memory_hotplug",

	"syscall_or_cpuset",

	"mempolicy_mbind",

	"numa_misplaced",

	"cma",

};



const struct trace_print_flags pageflag_names[] = {

const struct trace_print_flags pageflag_names[] = {

	__def_pageflag_names,

	__def_pageflag_names,

	{0, NULL}

	{0, NULL}

mm/migrate.c

+7 −3
Original line number Original line Diff line number Diff line
@@ -955,8 +955,10 @@ static ICE_noinline int unmap_and_move(new_page_t get_new_page, 
	}

	}





	rc = __unmap_and_move(page, newpage, force, mode);

	rc = __unmap_and_move(page, newpage, force, mode);

	if (rc == MIGRATEPAGE_SUCCESS)

	if (rc == MIGRATEPAGE_SUCCESS) {

		put_new_page = NULL;

		put_new_page = NULL;

		set_page_owner_migrate_reason(newpage, reason);

	}





out:

out:

	if (rc != -EAGAIN) {

	if (rc != -EAGAIN) {
@@ -1021,7 +1023,7 @@ out: 
static int unmap_and_move_huge_page(new_page_t get_new_page,

static int unmap_and_move_huge_page(new_page_t get_new_page,

				free_page_t put_new_page, unsigned long private,

				free_page_t put_new_page, unsigned long private,

				struct page *hpage, int force,

				struct page *hpage, int force,

				enum migrate_mode mode)

				enum migrate_mode mode, int reason)

{

{

	int rc = -EAGAIN;

	int rc = -EAGAIN;

	int *result = NULL;

	int *result = NULL;
@@ -1079,6 +1081,7 @@ put_anon: 
	if (rc == MIGRATEPAGE_SUCCESS) {

	if (rc == MIGRATEPAGE_SUCCESS) {

		hugetlb_cgroup_migrate(hpage, new_hpage);

		hugetlb_cgroup_migrate(hpage, new_hpage);

		put_new_page = NULL;

		put_new_page = NULL;

		set_page_owner_migrate_reason(new_hpage, reason);

	}

	}





	unlock_page(hpage);

	unlock_page(hpage);
@@ -1151,7 +1154,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, 
			if (PageHuge(page))

			if (PageHuge(page))

				rc = unmap_and_move_huge_page(get_new_page,

				rc = unmap_and_move_huge_page(get_new_page,

						put_new_page, private, page,

						put_new_page, private, page,

						pass > 2, mode);

						pass > 2, mode, reason);

			else

			else

				rc = unmap_and_move(get_new_page, put_new_page,

				rc = unmap_and_move(get_new_page, put_new_page,

						private, page, pass > 2, mode,

						private, page, pass > 2, mode,
@@ -1842,6 +1845,7 @@ fail_putback: 
	set_page_memcg(new_page, page_memcg(page));

	set_page_memcg(new_page, page_memcg(page));

	set_page_memcg(page, NULL);

	set_page_memcg(page, NULL);

	page_remove_rmap(page, true);

	page_remove_rmap(page, true);

	set_page_owner_migrate_reason(new_page, MR_NUMA_MISPLACED);





	spin_unlock(ptl);

	spin_unlock(ptl);

	mmu_notifier_invalidate_range_end(mm, mmun_start, mmun_end);

	mmu_notifier_invalidate_range_end(mm, mmun_start, mmun_end);

CRA Git | Maintained and supported by SUSTech CRA and CCSE