checkpatch: additional MAINTAINER section entry ordering checks (7ccf41a8) · Commits · 戴 / test

scripts/checkpatch.pl

+37 −8

Original line number	Diff line number	Diff line
		@@ -3062,9 +3062,10 @@ sub process {
		#print "is_start<$is_start> is_end<$is_end> length<$length>\n";
		}

		# check for MAINTAINERS entries that don't have the right form
		if ($realfile =~ /^MAINTAINERS$/ &&
		$rawline =~ /^\+[A-Z]:/ &&
		# check MAINTAINERS entries
		if ($realfile =~ /^MAINTAINERS$/) {
		# check MAINTAINERS entries for the right form
		if ($rawline =~ /^\+[A-Z]:/ &&
		$rawline !~ /^\+[A-Z]:\t\S/) {
		if (WARN("MAINTAINERS_STYLE",
		"MAINTAINERS entries use one tab after TYPE:\n" . $herecurr) &&
		@@ -3072,6 +3073,34 @@ sub process {
		$fixed[$fixlinenr] =~ s/^(\+[A-Z]):\s*/$1:\t/;
		}
		}
		# check MAINTAINERS entries for the right ordering too
		my $preferred_order = 'MRLSWQBCPTFXNK';
		if ($rawline =~ /^\+[A-Z]:/ &&
		$prevrawline =~ /^[\+ ][A-Z]:/) {
		$rawline =~ /^\+([A-Z]):\s(.)/;
		my $cur = $1;
		my $curval = $2;
		$prevrawline =~ /^[\+ ]([A-Z]):\s(.)/;
		my $prev = $1;
		my $prevval = $2;
		my $curindex = index($preferred_order, $cur);
		my $previndex = index($preferred_order, $prev);
		if ($curindex < 0) {
		WARN("MAINTAINERS_STYLE",
		"Unknown MAINTAINERS entry type: '$cur'\n" . $herecurr);
		} else {
		if ($previndex >= 0 && $curindex < $previndex) {
		WARN("MAINTAINERS_STYLE",
		"Misordered MAINTAINERS entry - list '$cur:' before '$prev:'\n" . $hereprev);
		} elsif ((($prev eq 'F' && $cur eq 'F') \|\|
		($prev eq 'X' && $cur eq 'X')) &&
		($prevval cmp $curval) > 0) {
		WARN("MAINTAINERS_STYLE",
		"Misordered MAINTAINERS entry - list file patterns in alphabetic order\n" . $hereprev);
		}
		}
		}
		}

		# discourage the use of boolean for type definition attributes of Kconfig options
		if ($realfile =~ /Kconfig/ &&

Admin message