Commit 7ccefb98 authored Mar 29, 2016 by Yauhen Kharuzhy Committed by David Sterba Apr 04, 2016

btrfs: Reset IO error counters before start of device replacing



If device replace entry was found on disk at mounting and its num_write_errors
stats counter has non-NULL value, then replace operation will never be
finished and -EIO error will be reported by btrfs_scrub_dev() because
this counter is never reset.

 # mount -o degraded /media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/
 # btrfs replace status /media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/
 Started on 25.Mar 07:28:00, canceled on 25.Mar 07:28:01 at 0.0%, 40 write errs, 0 uncorr. read errs
 # btrfs replace start -B 4 /dev/sdg /media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/
 ERROR: ioctl(DEV_REPLACE_START) failed on "/media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/": Input/output error, no error

Reset num_write_errors and num_uncorrectable_read_errors counters in the
dev_replace structure before start of replacing.

Signed-off-by: Yauhen Kharuzhy <yauhen.kharuzhy@zavadatar.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 0f5dcf8d

fs/btrfs/dev-replace.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -394,6 +394,8 @@ int btrfs_dev_replace_start(struct btrfs_root *root,
		dev_replace->cursor_right = 0;
		dev_replace->is_valid = 1;
		dev_replace->item_needs_writeback = 1;
		atomic64_set(&dev_replace->num_write_errors, 0);
		atomic64_set(&dev_replace->num_uncorrectable_read_errors, 0);
		args->result = BTRFS_IOCTL_DEV_REPLACE_RESULT_NO_ERROR;
		btrfs_dev_replace_unlock(dev_replace, 1);

Admin message