Commit 7cc5bf9a authored by Dan Williams's avatar Dan Williams
Browse files

dmaengine: track the number of clients using a channel 



Haavard's dma-slave interface would like to test for exclusive access to a
channel.  The standard channel refcounting is not sufficient in that it
tracks more than just client references, it is also inaccurate as reference
counts are percpu until the channel is removed.

This change also enables a future fix to deallocate resources when a client
declines to use a capable channel.

Acked-by: default avatarHaavard Skinnemoen <haavard.skinnemoen@atmel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 9c402f4e

drivers/dma/dmaengine.c

+10 −4
Original line number Diff line number Diff line
@@ -183,9 +183,10 @@ static void dma_client_chan_alloc(struct dma_client *client) 
				/* we are done once this client rejects

				 * an available resource

				 */

				if (ack == DMA_ACK)

				if (ack == DMA_ACK) {

					dma_chan_get(chan);

				else if (ack == DMA_NAK)

					chan->client_count++;

				} else if (ack == DMA_NAK)

					return;

			}

		}
@@ -272,8 +273,10 @@ static void dma_clients_notify_removed(struct dma_chan *chan) 
		/* client was holding resources for this channel so

		 * free it

		 */

		if (ack == DMA_ACK)

		if (ack == DMA_ACK) {

			dma_chan_put(chan);

			chan->client_count--;

		}

	}



	mutex_unlock(&dma_list_mutex);
@@ -313,8 +316,10 @@ void dma_async_client_unregister(struct dma_client *client) 
			ack = client->event_callback(client, chan,

				DMA_RESOURCE_REMOVED);



			if (ack == DMA_ACK)

			if (ack == DMA_ACK) {

				dma_chan_put(chan);

				chan->client_count--;

			}

		}



	list_del(&client->global_node);
@@ -394,6 +399,7 @@ int dma_async_device_register(struct dma_device *device) 
		kref_get(&device->refcount);

		kref_get(&device->refcount);

		kref_init(&chan->refcount);

		chan->client_count = 0;

		chan->slow_ref = 0;

		INIT_RCU_HEAD(&chan->rcu);

	}

include/linux/dmaengine.h

+2 −0
Original line number Diff line number Diff line
@@ -139,6 +139,7 @@ struct dma_chan_percpu { 
 * @rcu: the DMA channel's RCU head

 * @device_node: used to add this to the device chan list

 * @local: per-cpu pointer to a struct dma_chan_percpu

 * @client-count: how many clients are using this channel

 */

struct dma_chan {

	struct dma_device *device;
@@ -154,6 +155,7 @@ struct dma_chan { 


	struct list_head device_node;

	struct dma_chan_percpu *local;

	int client_count;

};



#define to_dma_chan(p) container_of(p, struct dma_chan, dev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE