ath10k: enable firmware log by default for sdio (7cbf4c96) · Commits · 戴 / test

On SDIO chips the firmware log does not impact performance. To make it easier to debug firmware problems keep it enabled on the firmware. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. Signed-off-by:

Wen Gong <wgong@codeaurora.org> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/ath/ath10k/core.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -715,18 +715,6 @@ static int ath10k_init_sdio(struct ath10k *ar, enum ath10k_firmware_mode mode)
		if (ret)
		return ret;

		/* Explicitly set fwlog prints to zero as target may turn it on
		* based on scratch registers.
		*/
		ret = ath10k_bmi_read32(ar, hi_option_flag, &param);
		if (ret)
		return ret;

		param \|= HI_OPTION_DISABLE_DBGLOG;
		ret = ath10k_bmi_write32(ar, hi_option_flag, param);
		if (ret)
		return ret;

		return 0;
		}

Admin message