Commit 7cb85fc4 authored Feb 18, 2020 by Sean Christopherson Committed by Paolo Bonzini May 27, 2020

KVM: x86: Remove superfluous brackets from case statement

Remove unnecessary brackets from a case statement that unintentionally
encapsulates unrelated case statements in the same switch statement.
While technically legal and functionally correct syntax, the brackets
are visually confusing and potentially dangerous, e.g. the last of the
encapsulated case statements has an undocumented fall-through that isn't
flagged by compilers due the encapsulation.

Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Message-Id: <20200218234012.7110-2-sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent df2a69af

arch/x86/kvm/x86.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -5303,7 +5303,7 @@ static void kvm_init_msr_list(void)
		!intel_pt_validate_hw_cap(PT_CAP_single_range_output)))
		continue;
		break;
		case MSR_IA32_RTIT_ADDR0_A ... MSR_IA32_RTIT_ADDR3_B: {
		case MSR_IA32_RTIT_ADDR0_A ... MSR_IA32_RTIT_ADDR3_B:
		if (!kvm_cpu_cap_has(X86_FEATURE_INTEL_PT) \|\|
		msrs_to_save_all[i] - MSR_IA32_RTIT_ADDR0_A >=
		intel_pt_validate_hw_cap(PT_CAP_num_address_ranges) * 2)
		@@ -5318,7 +5318,7 @@ static void kvm_init_msr_list(void)
		if (msrs_to_save_all[i] - MSR_ARCH_PERFMON_EVENTSEL0 >=
		min(INTEL_PMC_MAX_GENERIC, x86_pmu.num_counters_gp))
		continue;
		}
		break;
		default:
		break;
		}

Admin message