Commit 7c8cf2fe authored Feb 23, 2011 by Chad Dupuis Committed by James Bottomley Feb 25, 2011

[SCSI] qla2xxx: Fix array subscript is above array bounds in qla2xx_build_scsi_type_6_iocbs().



The additional increment of dsd_seg was causing the compiler to throw an array
out of bounds warning. This patch moves to a direct assignment of
cmd_pkt->fcp_data_dseg_len so that the compiler doesn't generate an array out
bounds warning.

Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: Madhuranath Iyengar <Madhu.Iyengar@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent f5e3e40b

drivers/scsi/qla2xxx/qla_nx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2547,7 +2547,7 @@ qla2xx_build_scsi_type_6_iocbs(srb_t sp, struct cmd_type_6 cmd_pkt,
		dsd_seg = (uint32_t *)&cmd_pkt->fcp_data_dseg_address;
		*dsd_seg++ = cpu_to_le32(LSD(dsd_ptr->dsd_list_dma));
		*dsd_seg++ = cpu_to_le32(MSD(dsd_ptr->dsd_list_dma));
		*dsd_seg++ = dsd_list_len;
		cmd_pkt->fcp_data_dseg_len = dsd_list_len;
		} else {
		*cur_dsd++ = cpu_to_le32(LSD(dsd_ptr->dsd_list_dma));
		*cur_dsd++ = cpu_to_le32(MSD(dsd_ptr->dsd_list_dma));

Admin message