smsc95xx: check return value of smsc95xx_reset (7c8b1e85) · Commits · 戴 / test

The return value of the function smsc95xx_reset() must be checked to avoid returning false success from the function smsc95xx_bind(). Fixes: ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver") Signed-off-by:

Andre Edich <andre.edich@microchip.com> Signed-off-by:

Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/usb/smsc95xx.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1287,6 +1287,8 @@ static int smsc95xx_bind(struct usbnet dev, struct usb_interface intf)

		/* Init all registers */
		ret = smsc95xx_reset(dev);
		if (ret)
		goto free_pdata;

		/* detect device revision as different features may be available */
		ret = smsc95xx_read_reg(dev, ID_REV, &val);
		@@ -1317,6 +1319,10 @@ static int smsc95xx_bind(struct usbnet dev, struct usb_interface intf)
		schedule_delayed_work(&pdata->carrier_check, CARRIER_CHECK_DELAY);

		return 0;

		free_pdata:
		kfree(pdata);
		return ret;
		}

		static void smsc95xx_unbind(struct usbnet dev, struct usb_interface intf)

Admin message