Commit 7c839120 authored by Christoph Lameter's avatar Christoph Lameter Committed by Tejun Heo
Browse files

vmstat: User per cpu atomics to avoid interrupt disable / enable 



Currently the operations to increment vm counters must disable interrupts
in order to not mess up their housekeeping of counters.

So use this_cpu_cmpxchg() to avoid the overhead. Since we can no longer
count on preremption being disabled we still have some minor issues.
The fetching of the counter thresholds is racy.
A threshold from another cpu may be applied if we happen to be
rescheduled on another cpu.  However, the following vmstat operation
will then bring the counter again under the threshold limit.

The operations for __xxx_zone_state are not changed since the caller
has taken care of the synchronization needs (and therefore the cycle
count is even less than the optimized version for the irq disable case
provided here).

The optimization using this_cpu_cmpxchg will only be used if the arch
supports efficient this_cpu_ops (must have CONFIG_CMPXCHG_LOCAL set!)

The use of this_cpu_cmpxchg reduces the cycle count for the counter
operations by %80 (inc_zone_page_state goes from 170 cycles to 32).

Signed-off-by: default avatarChristoph Lameter <cl@linux.com>
parent 20b87691

mm/vmstat.c

+87 −14
Original line number Diff line number Diff line
@@ -184,20 +184,6 @@ void __mod_zone_page_state(struct zone *zone, enum zone_stat_item item, 
}

EXPORT_SYMBOL(__mod_zone_page_state);



/*

 * For an unknown interrupt state

 */

void mod_zone_page_state(struct zone *zone, enum zone_stat_item item,

					int delta)

{

	unsigned long flags;



	local_irq_save(flags);

	__mod_zone_page_state(zone, item, delta);

	local_irq_restore(flags);

}

EXPORT_SYMBOL(mod_zone_page_state);



/*

 * Optimized increment and decrement functions.

 *
@@ -265,6 +251,92 @@ void __dec_zone_page_state(struct page *page, enum zone_stat_item item) 
}

EXPORT_SYMBOL(__dec_zone_page_state);



#ifdef CONFIG_CMPXCHG_LOCAL

/*

 * If we have cmpxchg_local support then we do not need to incur the overhead

 * that comes with local_irq_save/restore if we use this_cpu_cmpxchg.

 *

 * mod_state() modifies the zone counter state through atomic per cpu

 * operations.

 *

 * Overstep mode specifies how overstep should handled:

 *     0       No overstepping

 *     1       Overstepping half of threshold

 *     -1      Overstepping minus half of threshold

*/

static inline void mod_state(struct zone *zone,

       enum zone_stat_item item, int delta, int overstep_mode)

{

	struct per_cpu_pageset __percpu *pcp = zone->pageset;

	s8 __percpu *p = pcp->vm_stat_diff + item;

	long o, n, t, z;



	do {

		z = 0;  /* overflow to zone counters */



		/*

		 * The fetching of the stat_threshold is racy. We may apply

		 * a counter threshold to the wrong the cpu if we get

		 * rescheduled while executing here. However, the following

		 * will apply the threshold again and therefore bring the

		 * counter under the threshold.

		 */

		t = this_cpu_read(pcp->stat_threshold);



		o = this_cpu_read(*p);

		n = delta + o;



		if (n > t || n < -t) {

			int os = overstep_mode * (t >> 1) ;



			/* Overflow must be added to zone counters */

			z = n + os;

			n = -os;

		}

	} while (this_cpu_cmpxchg(*p, o, n) != o);



	if (z)

		zone_page_state_add(z, zone, item);

}



void mod_zone_page_state(struct zone *zone, enum zone_stat_item item,

					int delta)

{

	mod_state(zone, item, delta, 0);

}

EXPORT_SYMBOL(mod_zone_page_state);



void inc_zone_state(struct zone *zone, enum zone_stat_item item)

{

	mod_state(zone, item, 1, 1);

}



void inc_zone_page_state(struct page *page, enum zone_stat_item item)

{

	mod_state(page_zone(page), item, 1, 1);

}

EXPORT_SYMBOL(inc_zone_page_state);



void dec_zone_page_state(struct page *page, enum zone_stat_item item)

{

	mod_state(page_zone(page), item, -1, -1);

}

EXPORT_SYMBOL(dec_zone_page_state);

#else

/*

 * Use interrupt disable to serialize counter updates

 */

void mod_zone_page_state(struct zone *zone, enum zone_stat_item item,

					int delta)

{

	unsigned long flags;



	local_irq_save(flags);

	__mod_zone_page_state(zone, item, delta);

	local_irq_restore(flags);

}

EXPORT_SYMBOL(mod_zone_page_state);



void inc_zone_state(struct zone *zone, enum zone_stat_item item)

{

	unsigned long flags;
@@ -295,6 +367,7 @@ void dec_zone_page_state(struct page *page, enum zone_stat_item item) 
	local_irq_restore(flags);

}

EXPORT_SYMBOL(dec_zone_page_state);

#endif



/*

 * Update the zone counters for one cpu.

CRA Git | Maintained and supported by SUSTech CRA and CCSE