Commit 7c70b896 authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher
Browse files

gfs2: clean_journal improperly set sd_log_flush_head 



This patch fixes regressions in 588bff95.
Due to that patch, function clean_journal was setting the value of
sd_log_flush_head, but that's only valid if it is replaying the node's
own journal. If it's replaying another node's journal, that's completely
wrong and will lead to multiple problems. This patch tries to clean up
the mess by passing the value of the logical journal block number into
gfs2_write_log_header so the function can treat non-owned journals
generically. For the local journal, the journal extent map is used for
best performance. For other nodes from other journals, new function
gfs2_lblk_to_dblk is called to figure it out using gfs2_iomap_get.

This patch also tries to establish more consistency when passing journal
block parameters by changing several unsigned int types to a consistent
u32.

Fixes: 588bff95 ("GFS2: Reduce code redundancy writing log headers")
Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 7881ef3f

fs/gfs2/bmap.c

+26 −0
Original line number Diff line number Diff line
@@ -925,6 +925,32 @@ do_alloc: 
	goto out;

}



/**

 * gfs2_lblk_to_dblk - convert logical block to disk block

 * @inode: the inode of the file we're mapping

 * @lblock: the block relative to the start of the file

 * @dblock: the returned dblock, if no error

 *

 * This function maps a single block from a file logical block (relative to

 * the start of the file) to a file system absolute block using iomap.

 *

 * Returns: the absolute file system block, or an error

 */

int gfs2_lblk_to_dblk(struct inode *inode, u32 lblock, u64 *dblock)

{

	struct iomap iomap = { };

	struct metapath mp = { .mp_aheight = 1, };

	loff_t pos = (loff_t)lblock << inode->i_blkbits;

	int ret;



	ret = gfs2_iomap_get(inode, pos, i_blocksize(inode), 0, &iomap, &mp);

	release_metapath(&mp);

	if (ret == 0)

		*dblock = iomap.addr >> inode->i_blkbits;



	return ret;

}



static int gfs2_write_lock(struct inode *inode)

{

	struct gfs2_inode *ip = GFS2_I(inode);

fs/gfs2/bmap.h

+1 −0
Original line number Diff line number Diff line
@@ -64,5 +64,6 @@ extern int gfs2_write_alloc_required(struct gfs2_inode *ip, u64 offset, 
extern int gfs2_map_journal_extents(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd);

extern void gfs2_free_journal_extents(struct gfs2_jdesc *jd);

extern int __gfs2_punch_hole(struct file *file, loff_t offset, loff_t length);

extern int gfs2_lblk_to_dblk(struct inode *inode, u32 lblock, u64 *dblock);



#endif /* __BMAP_DOT_H__ */

fs/gfs2/incore.h

+1 −1
Original line number Diff line number Diff line
@@ -535,7 +535,7 @@ struct gfs2_jdesc { 
	unsigned long jd_flags;

#define JDF_RECOVERY 1

	unsigned int jd_jid;

	unsigned int jd_blocks;

	u32 jd_blocks;

	int jd_recover_error;

	/* Replay stuff */

fs/gfs2/log.c

+16 −8
Original line number Diff line number Diff line
@@ -666,11 +666,12 @@ out_of_blocks: 
}



/**

 * write_log_header - Write a journal log header buffer at sd_log_flush_head

 * gfs2_write_log_header - Write a journal log header buffer at lblock

 * @sdp: The GFS2 superblock

 * @jd: journal descriptor of the journal to which we are writing

 * @seq: sequence number

 * @tail: tail of the log

 * @lblock: value for lh_blkno (block number relative to start of journal)

 * @flags: log header flags GFS2_LOG_HEAD_*

 * @op_flags: flags to pass to the bio

 *
@@ -678,7 +679,8 @@ out_of_blocks: 
 */



void gfs2_write_log_header(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd,

			   u64 seq, u32 tail, u32 flags, int op_flags)

			   u64 seq, u32 tail, u32 lblock, u32 flags,

			   int op_flags)

{

	struct gfs2_log_header *lh;

	u32 hash, crc;
@@ -686,7 +688,7 @@ void gfs2_write_log_header(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd, 
	struct gfs2_statfs_change_host *l_sc = &sdp->sd_statfs_local;

	struct timespec64 tv;

	struct super_block *sb = sdp->sd_vfs;

	u64 addr;

	u64 dblock;



	lh = page_address(page);

	clear_page(lh);
@@ -699,15 +701,21 @@ void gfs2_write_log_header(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd, 
	lh->lh_sequence = cpu_to_be64(seq);

	lh->lh_flags = cpu_to_be32(flags);

	lh->lh_tail = cpu_to_be32(tail);

	lh->lh_blkno = cpu_to_be32(sdp->sd_log_flush_head);

	lh->lh_blkno = cpu_to_be32(lblock);

	hash = ~crc32(~0, lh, LH_V1_SIZE);

	lh->lh_hash = cpu_to_be32(hash);



	ktime_get_coarse_real_ts64(&tv);

	lh->lh_nsec = cpu_to_be32(tv.tv_nsec);

	lh->lh_sec = cpu_to_be64(tv.tv_sec);

	addr = gfs2_log_bmap(sdp);

	lh->lh_addr = cpu_to_be64(addr);

	if (!list_empty(&jd->extent_list))

		dblock = gfs2_log_bmap(sdp);

	else {

		int ret = gfs2_lblk_to_dblk(jd->jd_inode, lblock, &dblock);

		if (gfs2_assert_withdraw(sdp, ret == 0))

			return;

	}

	lh->lh_addr = cpu_to_be64(dblock);

	lh->lh_jinode = cpu_to_be64(GFS2_I(jd->jd_inode)->i_no_addr);



	/* We may only write local statfs, quota, etc., when writing to our
@@ -732,7 +740,7 @@ void gfs2_write_log_header(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd, 
		     sb->s_blocksize - LH_V1_SIZE - 4);

	lh->lh_crc = cpu_to_be32(crc);



	gfs2_log_write(sdp, page, sb->s_blocksize, 0, addr);

	gfs2_log_write(sdp, page, sb->s_blocksize, 0, dblock);

	gfs2_log_submit_bio(&sdp->sd_log_bio, REQ_OP_WRITE, op_flags);

	log_flush_wait(sdp);

}
@@ -761,7 +769,7 @@ static void log_write_header(struct gfs2_sbd *sdp, u32 flags) 
	}

	sdp->sd_log_idle = (tail == sdp->sd_log_flush_head);

	gfs2_write_log_header(sdp, sdp->sd_jdesc, sdp->sd_log_sequence++, tail,

			      flags, op_flags);

			      sdp->sd_log_flush_head, flags, op_flags);



	if (sdp->sd_log_tail != tail)

		log_pull_tail(sdp, tail);

fs/gfs2/log.h

+2 −1
Original line number Diff line number Diff line
@@ -70,7 +70,8 @@ extern unsigned int gfs2_struct2blk(struct gfs2_sbd *sdp, unsigned int nstruct, 
extern void gfs2_log_release(struct gfs2_sbd *sdp, unsigned int blks);

extern int gfs2_log_reserve(struct gfs2_sbd *sdp, unsigned int blks);

extern void gfs2_write_log_header(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd,

				  u64 seq, u32 tail, u32 flags, int op_flags);

				  u64 seq, u32 tail, u32 lblock, u32 flags,

				  int op_flags);

extern void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl,

			   u32 type);

extern void gfs2_log_commit(struct gfs2_sbd *sdp, struct gfs2_trans *trans);

CRA Git | Maintained and supported by SUSTech CRA and CCSE