x86: i8259A: remove redundant irq_descinitialization (7c6357da) · Commits · 戴 / test

Remove redundant irq_desc[NR_IRQS] element initialization in init_ISA_irqs(). irq_desc[NR_IRQS] is already statically initialized with the same values in kernel/irq/handle.c . besides the clean-up value this also saves some space: text data bss dec hex filename 1389 356 14 1759 6df i8259_32.o.before 1325 356 14 1695 69f i8259_32.o.after Signed-off-by:

Ahmed S. Darwish <darwish.07@gmail.com> Signed-off-by:

Ingo Molnar <mingo@elte.hu> Signed-off-by:

Thomas Gleixner <tglx@linutronix.de>

arch/x86/kernel/i8259_32.c

+6 −19

Original line number	Diff line number	Diff line
		@@ -26,8 +26,6 @@
		* present in the majority of PC/AT boxes.
		* plus some generic x86 specific things if generic specifics makes
		* any sense at all.
		* this file should become arch/i386/kernel/irq.c when the old irq.c
		* moves to arch independent land
		*/

		static int i8259A_auto_eoi;
		@@ -362,23 +360,12 @@ void __init init_ISA_irqs (void)
		#endif
		init_8259A(0);

		for (i = 0; i < NR_IRQS; i++) {
		irq_desc[i].status = IRQ_DISABLED;
		irq_desc[i].action = NULL;
		irq_desc[i].depth = 1;

		if (i < 16) {
		/*
		* 16 old-style INTA-cycle interrupts:
		*/
		for (i = 0; i < 16; i++) {
		set_irq_chip_and_handler_name(i, &i8259A_chip,
		handle_level_irq, "XT");
		} else {
		/*
		* 'high' PCI IRQs filled in on demand
		*/
		irq_desc[i].chip = &no_irq_chip;
		}
		}
		}

Admin message