Commit 7c4a7292 authored Nov 25, 2018 by Ido Schimmel Committed by David S. Miller Nov 27, 2018

mlxsw: spectrum_fid: Make flood index calculation more robust



802.1D FIDs use a per-FID flood table, where the flood index into the
table is calculated by subtracting 4K from the FID's index.

Currently, 802.1D FIDs start at 4K, so the calculation is correct, but
if it was ever to change, the calculation will no longer be correct.

In addition, this change will allow us to reuse the flood index
calculation function in the next patch, where we are going to emulate
802.1Q FIDs using 802.1D FIDs.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6502be9f

drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -607,7 +607,7 @@ mlxsw_sp_fid_8021d_compare(const struct mlxsw_sp_fid fid, const void arg)

		static u16 mlxsw_sp_fid_8021d_flood_index(const struct mlxsw_sp_fid *fid)
		{
		return fid->fid_index - fid->fid_family->start_index;
		return fid->fid_index - VLAN_N_VID;
		}

		static int mlxsw_sp_port_vp_mode_trans(struct mlxsw_sp_port *mlxsw_sp_port)

Admin message