Commit 7c497478 authored by Jason Wang's avatar Jason Wang Committed by David S. Miller
Browse files

net: export some generic xdp helpers 



This patch tries to export some generic xdp helpers to drivers. This
can let driver to do XDP for a specific skb. This is useful for the
case when the packet is hard to be processed at page level directly
(e.g jumbo/GSO frame).

With this patch, there's no need for driver to forbid the XDP set when
configuration is not suitable. Instead, it can defer the XDP for
packets that is hard to be processed directly after skb is created.

Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 66ccbc9c

include/linux/netdevice.h

+2 −0
Original line number Diff line number Diff line
@@ -3243,6 +3243,8 @@ static inline void dev_consume_skb_any(struct sk_buff *skb) 
	__dev_kfree_skb_any(skb, SKB_REASON_CONSUMED);

}



void generic_xdp_tx(struct sk_buff *skb, struct bpf_prog *xdp_prog);

int do_xdp_generic(struct bpf_prog *xdp_prog, struct sk_buff *skb);

int netif_rx(struct sk_buff *skb);

int netif_rx_ni(struct sk_buff *skb);

int netif_receive_skb(struct sk_buff *skb);

net/core/dev.c

+8 −6
Original line number Diff line number Diff line
@@ -3919,7 +3919,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb, 
/* When doing generic XDP we have to bypass the qdisc layer and the

 * network taps in order to match in-driver-XDP behavior.

 */

static void generic_xdp_tx(struct sk_buff *skb, struct bpf_prog *xdp_prog)

void generic_xdp_tx(struct sk_buff *skb, struct bpf_prog *xdp_prog)

{

	struct net_device *dev = skb->dev;

	struct netdev_queue *txq;
@@ -3940,13 +3940,12 @@ static void generic_xdp_tx(struct sk_buff *skb, struct bpf_prog *xdp_prog) 
		kfree_skb(skb);

	}

}

EXPORT_SYMBOL_GPL(generic_xdp_tx);



static struct static_key generic_xdp_needed __read_mostly;



static int do_xdp_generic(struct sk_buff *skb)

int do_xdp_generic(struct bpf_prog *xdp_prog, struct sk_buff *skb)

{

	struct bpf_prog *xdp_prog = rcu_dereference(skb->dev->xdp_prog);



	if (xdp_prog) {

		u32 act = netif_receive_generic_xdp(skb, xdp_prog);

		int err;
@@ -3971,6 +3970,7 @@ out_redir: 
	kfree_skb(skb);

	return XDP_DROP;

}

EXPORT_SYMBOL_GPL(do_xdp_generic);



static int netif_rx_internal(struct sk_buff *skb)

{
@@ -3981,7 +3981,8 @@ static int netif_rx_internal(struct sk_buff *skb) 
	trace_netif_rx(skb);



	if (static_key_false(&generic_xdp_needed)) {

		int ret = do_xdp_generic(skb);

		int ret = do_xdp_generic(rcu_dereference(skb->dev->xdp_prog),

					 skb);



		/* Consider XDP consuming the packet a success from

		 * the netdev point of view we do not want to count
@@ -4502,7 +4503,8 @@ static int netif_receive_skb_internal(struct sk_buff *skb) 
	rcu_read_lock();



	if (static_key_false(&generic_xdp_needed)) {

		int ret = do_xdp_generic(skb);

		int ret = do_xdp_generic(rcu_dereference(skb->dev->xdp_prog),

					 skb);



		if (ret != XDP_PASS) {

			rcu_read_unlock();

CRA Git | Maintained and supported by SUSTech CRA and CCSE