Commit 7c45512d authored by Linus Torvalds's avatar Linus Torvalds
Browse files

mm: fix pageblock bitmap allocation 



Commit c060f943 ("mm: use aligned zone start for pfn_to_bitidx
calculation") fixed out calculation of the index into the pageblock
bitmap when a !SPARSEMEM zome was not aligned to pageblock_nr_pages.

However, the _allocation_ of that bitmap had never taken this alignment
requirement into accout, so depending on the exact size and alignment of
the zone, the use of that index could then access past the allocation,
resulting in some very subtle memory corruption.

This was reported (and bisected) by Ingo Molnar: one of his random
config builds would hang with certain very specific kernel command line
options.

In the meantime, commit c060f943 has been marked for stable, so this
fix needs to be back-ported to the stable kernels that backported the
commit to use the right alignment.

Bisected-and-tested-by: default avatarIngo Molnar <mingo@kernel.org>
Acked-by: default avatarMel Gorman <mgorman@suse.de>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f741656d

mm/page_alloc.c

+9 −6
Original line number Diff line number Diff line
@@ -4420,10 +4420,11 @@ static void __meminit calculate_node_totalpages(struct pglist_data *pgdat, 
 * round what is now in bits to nearest long in bits, then return it in

 * bytes.

 */

static unsigned long __init usemap_size(unsigned long zonesize)

static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned long zonesize)

{

	unsigned long usemapsize;



	zonesize += zone_start_pfn & (pageblock_nr_pages-1);

	usemapsize = roundup(zonesize, pageblock_nr_pages);

	usemapsize = usemapsize >> pageblock_order;

	usemapsize *= NR_PAGEBLOCK_BITS;
@@ -4433,17 +4434,19 @@ static unsigned long __init usemap_size(unsigned long zonesize) 
}



static void __init setup_usemap(struct pglist_data *pgdat,

				struct zone *zone, unsigned long zonesize)

				struct zone *zone,

				unsigned long zone_start_pfn,

				unsigned long zonesize)

{

	unsigned long usemapsize = usemap_size(zonesize);

	unsigned long usemapsize = usemap_size(zone_start_pfn, zonesize);

	zone->pageblock_flags = NULL;

	if (usemapsize)

		zone->pageblock_flags = alloc_bootmem_node_nopanic(pgdat,

								   usemapsize);

}

#else

static inline void setup_usemap(struct pglist_data *pgdat,

				struct zone *zone, unsigned long zonesize) {}

static inline void setup_usemap(struct pglist_data *pgdat, struct zone *zone,

				unsigned long zone_start_pfn, unsigned long zonesize) {}

#endif /* CONFIG_SPARSEMEM */



#ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE
@@ -4594,7 +4597,7 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat, 
			continue;



		set_pageblock_order();

		setup_usemap(pgdat, zone, size);

		setup_usemap(pgdat, zone, zone_start_pfn, size);

		ret = init_currently_empty_zone(zone, zone_start_pfn,

						size, MEMMAP_EARLY);

		BUG_ON(ret);

CRA Git | Maintained and supported by SUSTech CRA and CCSE