Commit 7c3f4309 authored Mar 01, 2017 by Colin Ian King Committed by Vinod Koul Mar 14, 2017

dmaengine: mv_xor: remove redundant null check on cd



The check to see if cd is null is redundant, pdata->channels is
never null at this point, and hence &pdata->channels[i] cannot
be null, so remove the null check.

Detected by CoverityScan, CID#1357194 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 041cf7e0

drivers/dma/mv_xor.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1580,11 +1580,6 @@ static int mv_xor_probe(struct platform_device *pdev)
		int irq;

		cd = &pdata->channels[i];
		if (!cd) {
		ret = -ENODEV;
		goto err_channel_add;
		}

		irq = platform_get_irq(pdev, i);
		if (irq < 0) {
		ret = irq;

Admin message