Commit 7c35e699 authored Dec 06, 2019 by Geert Uytterhoeven Committed by Greg Kroah-Hartman Jan 14, 2020

driver core: Print device when resources present in really_probe()



If a device already has devres items attached before probing, a warning
backtrace is printed.  However, this backtrace does not reveal the
offending device, leaving the user uninformed.  Furthermore, using
WARN_ON() causes systems with panic-on-warn to reboot.

Fix this by replacing the WARN_ON() by a dev_crit() message.
Abort probing the device, to prevent doing more damage to the device's
resources.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20191206132219.28908-1-geert+renesas@glider.be


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 264d2527

drivers/base/dd.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -516,7 +516,10 @@ static int really_probe(struct device dev, struct device_driver drv)
		atomic_inc(&probe_count);
		pr_debug("bus: '%s': %s: probing driver %s with device %s\n",
		drv->bus->name, __func__, drv->name, dev_name(dev));
		WARN_ON(!list_empty(&dev->devres_head));
		if (!list_empty(&dev->devres_head)) {
		dev_crit(dev, "Resources present before probing\n");
		return -EBUSY;
		}

		re_probe:
		dev->driver = drv;

Admin message