Commit 7c2dad99 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Don't let the ctime override attribute barriers. 



Chuck reports seeing cases where a GETATTR that happens to race
with an asynchronous WRITE is overriding the file size, despite
the attribute barrier being set by the writeback code.

The culprit turns out to be the check in nfs_ctime_need_update(),
which sees that the ctime is newer than the cached ctime, and
assumes that it is safe to override the attribute barrier.
This patch removes that override, and ensures that attribute
barriers are always respected.

Reported-by: default avatarChuck Lever <chuck.lever@oracle.com>
Fixes: a08a8cd3 ("NFS: Add attribute update barriers to NFS writebacks")
Cc: stable@vger.kernel.org # v4.0+
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 74918f93

fs/nfs/inode.c

+0 −8
Original line number Diff line number Diff line
@@ -1267,13 +1267,6 @@ static int nfs_check_inode_attributes(struct inode *inode, struct nfs_fattr *fat 
	return 0;

}



static int nfs_ctime_need_update(const struct inode *inode, const struct nfs_fattr *fattr)

{

	if (!(fattr->valid & NFS_ATTR_FATTR_CTIME))

		return 0;

	return timespec_compare(&fattr->ctime, &inode->i_ctime) > 0;

}



static atomic_long_t nfs_attr_generation_counter;



static unsigned long nfs_read_attr_generation_counter(void)
@@ -1422,7 +1415,6 @@ static int nfs_inode_attrs_need_update(const struct inode *inode, const struct n 
	const struct nfs_inode *nfsi = NFS_I(inode);



	return ((long)fattr->gencount - (long)nfsi->attr_gencount) > 0 ||

		nfs_ctime_need_update(inode, fattr) ||

		((long)nfsi->attr_gencount - (long)nfs_read_attr_generation_counter() > 0);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE