Commit 7c26e6ef authored Dec 20, 2019 by Fenghua Yu Committed by Miquel Raynal May 10, 2020

mtd: rawnand: fsmc: Change to non-atomic bit operations



No need to use expensive atomic change_bit() on dat[] and err_idx[]:
1. fsmc_bch8_correct_data() is called while mutex chip->lock is held
2. err_idx[] is a local variable.

To avoid big endian concern due to type cast to unsigned long, directly
change the bit in the specified byte instead of using non-atomic
__change_bit().

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/1576886755-9788-1-git-send-email-fenghua.yu@intel.com

parent 6a8b55ed

drivers/mtd/nand/raw/fsmc_nand.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -809,11 +809,12 @@ static int fsmc_bch8_correct_data(struct nand_chip chip, u8 dat,

		i = 0;
		while (num_err--) {
		change_bit(0, (unsigned long *)&err_idx[i]);
		change_bit(1, (unsigned long *)&err_idx[i]);
		err_idx[i] ^= 3;

		if (err_idx[i] < chip->ecc.size * 8) {
		change_bit(err_idx[i], (unsigned long *)dat);
		int err = err_idx[i];

		dat[err >> 3] ^= BIT(err & 7);
		i++;
		}
		}

Admin message