gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration (7c263fe0) · Commits · 戴 / test

Use devm_gpiochip_add_data() for GPIO registration and remove the call for gpiochip_remove() from remove callback. Signed-off-by:

Laxman Dewangan <ldewangan@nvidia.com> Cc: Michael Hennerich <michael.hennerich@analog.com> Acked-by:

drivers/gpio/gpio-adp5588.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -414,7 +414,7 @@ static int adp5588_gpio_probe(struct i2c_client *client,
		}
		}

		ret = gpiochip_add_data(&dev->gpio_chip, dev);
		ret = devm_gpiochip_add_data(&client->dev, &dev->gpio_chip, dev);
		if (ret)
		goto err_irq;

		@@ -457,8 +457,6 @@ static int adp5588_gpio_remove(struct i2c_client *client)
		if (dev->irq_base)
		free_irq(dev->client->irq, dev);

		gpiochip_remove(&dev->gpio_chip);

		return 0;
		}