Commit 7c0af9ff authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Don't call put_rpccred() under the rcu_read_lock() 



put_rpccred() can sleep.

Fixes: 8f649c37 ("NFSv4: Fix the locking in nfs_inode_reclaim_delegation()")
Cc: stable@vger.kernel.org # 2.6.35+
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent fa923369

fs/nfs/delegation.c

+1 −1
Original line number Diff line number Diff line
@@ -181,8 +181,8 @@ void nfs_inode_reclaim_delegation(struct inode *inode, struct rpc_cred *cred, 
			clear_bit(NFS_DELEGATION_NEED_RECLAIM,

				  &delegation->flags);

			spin_unlock(&delegation->lock);

			put_rpccred(oldcred);

			rcu_read_unlock();

			put_rpccred(oldcred);

			trace_nfs4_reclaim_delegation(inode, res->delegation_type);

		} else {

			/* We appear to have raced with a delegation return. */

CRA Git | Maintained and supported by SUSTech CRA and CCSE