Commit 7bfd82bf authored Oct 05, 2018 by Gustavo A. R. Silva Committed by Kalle Valo Oct 13, 2018

ath10k: remove unnecessary comparison of unsigned integer with < 0



There is no need to compare *ps_state_enable* with < 0 because
such variable is of type u8 (8 bits, unsigned), making it
impossible to hold a negative value.

Fix this by removing such comparison.

Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 9d9cdbf3

drivers/net/wireless/ath/ath10k/debug.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2421,7 +2421,7 @@ static ssize_t ath10k_write_ps_state_enable(struct file *file,
		if (kstrtou8_from_user(user_buf, count, 0, &ps_state_enable))
		return -EINVAL;

		if (ps_state_enable > 1 \|\| ps_state_enable < 0)
		if (ps_state_enable > 1)
		return -EINVAL;

		mutex_lock(&ar->conf_mutex);

Admin message