Commit 7bf8222b authored by Keith Busch's avatar Keith Busch Committed by Thomas Gleixner
Browse files

irq/affinity: Fix CPU spread for unbalanced nodes 



The irq_create_affinity_masks routine is responsible for assigning a
number of interrupt vectors to CPUs. The optimal assignemnet will spread
requested vectors to all CPUs, with the fewest CPUs sharing a vector.

The algorithm may fail to assign some vectors to any CPUs if a node's
CPU count is lower than the average number of vectors per node. These
vectors are unusable and create an un-optimal spread.

Recalculate the number of vectors to assign at each node iteration by using
the remaining number of vectors and nodes to be assigned, not exceeding the
number of CPUs in that node. This will guarantee that every CPU is assigned
at least one vector.

Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org
Link: http://lkml.kernel.org/r/1491247553-7603-1-git-send-email-keith.busch@intel.com


Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 08e4e0d0

kernel/irq/affinity.c

+11 −9
Original line number Diff line number Diff line
@@ -59,7 +59,7 @@ static int get_nodes_in_cpumask(const struct cpumask *mask, nodemask_t *nodemsk) 
struct cpumask *

irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd)

{

	int n, nodes, vecs_per_node, cpus_per_vec, extra_vecs, curvec;

	int n, nodes, cpus_per_vec, extra_vecs, curvec;

	int affv = nvecs - affd->pre_vectors - affd->post_vectors;

	int last_affv = affv + affd->pre_vectors;

	nodemask_t nodemsk = NODE_MASK_NONE;
@@ -94,19 +94,21 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) 
		goto done;

	}



	/* Spread the vectors per node */

	vecs_per_node = affv / nodes;

	/* Account for rounding errors */

	extra_vecs = affv - (nodes * vecs_per_node);



	for_each_node_mask(n, nodemsk) {

		int ncpus, v, vecs_to_assign = vecs_per_node;

		int ncpus, v, vecs_to_assign, vecs_per_node;



		/* Spread the vectors per node */

		vecs_per_node = (affv - curvec) / nodes;



		/* Get the cpus on this node which are in the mask */

		cpumask_and(nmsk, cpu_online_mask, cpumask_of_node(n));



		/* Calculate the number of cpus per vector */

		ncpus = cpumask_weight(nmsk);

		vecs_to_assign = min(vecs_per_node, ncpus);



		/* Account for rounding errors */

		extra_vecs = ncpus - vecs_to_assign;



		for (v = 0; curvec < last_affv && v < vecs_to_assign;

		     curvec++, v++) {
@@ -115,14 +117,14 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) 
			/* Account for extra vectors to compensate rounding errors */

			if (extra_vecs) {

				cpus_per_vec++;

				if (!--extra_vecs)

					vecs_per_node++;

				--extra_vecs;

			}

			irq_spread_init_one(masks + curvec, nmsk, cpus_per_vec);

		}



		if (curvec >= last_affv)

			break;

		--nodes;

	}



done:

CRA Git | Maintained and supported by SUSTech CRA and CCSE