Commit 7bf811a5 authored Oct 07, 2013 by Josef Bacik Committed by Chris Mason Oct 10, 2013

Btrfs: limit delalloc pages outside of find_delalloc_range



Liu fixed part of this problem and unfortunately I steered him in slightly the
wrong direction and so didn't completely fix the problem.  The problem is we
limit the size of the delalloc range we are looking for to max bytes and then we
try to lock that range.  If we fail to lock the pages in that range we will
shrink the max bytes to a single page and re loop.  However if our first page is
inside of the delalloc range then we will end up limiting the end of the range
to a period before our first page.  This is illustrated below

[0 -------- delalloc range --------- 256mb]
                                  [page]

So find_delalloc_range will return with delalloc_start as 0 and end as 128mb,
and then we will notice that delalloc_start < *start and adjust it up, but not
adjust delalloc_end up, so things go sideways.  To fix this we need to not limit
the max bytes in find_delalloc_range, but in find_lock_delalloc_range and that
way we don't end up with this confusion.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>

parent 4871c158

fs/btrfs/extent_io.c

+4 −8

Original line number	Diff line number	Diff line
		@@ -1482,10 +1482,8 @@ static noinline u64 find_delalloc_range(struct extent_io_tree *tree,
		cur_start = state->end + 1;
		node = rb_next(node);
		total_bytes += state->end - state->start + 1;
		if (total_bytes >= max_bytes) {
		end = start + max_bytes - 1;
		if (total_bytes >= max_bytes)
		break;
		}
		if (!node)
		break;
		}
		@@ -1627,10 +1625,9 @@ again:

		/*
		* make sure to limit the number of pages we try to lock down
		* if we're looping.
		*/
		if (delalloc_end + 1 - delalloc_start > max_bytes && loops)
		delalloc_end = delalloc_start + PAGE_CACHE_SIZE - 1;
		if (delalloc_end + 1 - delalloc_start > max_bytes)
		delalloc_end = delalloc_start + max_bytes - 1;

		/* step two, lock all the pages after the page that has start */
		ret = lock_delalloc_pages(inode, locked_page,
		@@ -1641,8 +1638,7 @@ again:
		*/
		free_extent_state(cached_state);
		if (!loops) {
		unsigned long offset = (*start) & (PAGE_CACHE_SIZE - 1);
		max_bytes = PAGE_CACHE_SIZE - offset;
		max_bytes = PAGE_CACHE_SIZE;
		loops = 1;
		goto again;
		} else {

Admin message