Commit 7bf47f60 authored Feb 15, 2020 by Sergei Shtylyov Committed by David S. Miller Feb 16, 2020

sh_eth: check sh_eth_cpu_data::no_xdfar when dumping registers



When adding the sh_eth_cpu_data::no_xdfar flag I forgot to add the flag
check to  __sh_eth_get_regs(), causing the non-existing RDFAR/TDFAR to be
considered for dumping on the R-Car gen1/2 SoCs (the register offset check
has the final say here)...

Fixes: 4c1d4585 ("sh_eth: add sh_eth_cpu_data::cexcr flag")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tested-by: Chris Brandt <chris.brandt@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f75ca324

drivers/net/ethernet/renesas/sh_eth.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2140,10 +2140,12 @@ static size_t __sh_eth_get_regs(struct net_device ndev, u32 buf)
		add_reg(EESR);
		add_reg(EESIPR);
		add_reg(TDLAR);
		if (!cd->no_xdfar)
		add_reg(TDFAR);
		add_reg(TDFXR);
		add_reg(TDFFR);
		add_reg(RDLAR);
		if (!cd->no_xdfar)
		add_reg(RDFAR);
		add_reg(RDFXR);
		add_reg(RDFFR);

Admin message