Commit 7be08153 authored Feb 16, 2012 by Gabor Juhos Committed by John W. Linville Feb 21, 2012

rt2x00: fix a possible NULL pointer dereference



The 'rt2x00lib_probe_dev' function tries to
allocate the workqueue. If the allocation
fails, 'rt2x00_lib_remove_dev' is called on
the error path. Because 'rt2x00dev->workqueue'
is NULL in this case, the 'destroy_workqueue'
call will cause a NULL pointer dereference.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 9bbb8168

drivers/net/wireless/rt2x00/rt2x00dev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1220,6 +1220,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
		cancel_work_sync(&rt2x00dev->rxdone_work);
		cancel_work_sync(&rt2x00dev->txdone_work);
		}
		if (rt2x00dev->workqueue)
		destroy_workqueue(rt2x00dev->workqueue);

		/*

Admin message