Commit 7bb633b1 authored Jan 29, 2017 by Guy Shapiro Committed by Alexandre Belloni Feb 01, 2017

rtc: snvs: add a missing write sync



The clear of the LPTA_EN flag should be synced before writing to the
alarm register. Omitting this synchronization creates a race when
trying to change existing alarm.

Signed-off-by: Guy Shapiro <guy.shapiro@mobi-wize.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 4c466872

drivers/rtc/rtc-snvs.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -184,6 +184,7 @@ static int snvs_rtc_set_alarm(struct device dev, struct rtc_wkalrm alrm)
		rtc_tm_to_time(alrm_tm, &time);

		regmap_update_bits(data->regmap, data->offset + SNVS_LPCR, SNVS_LPCR_LPTA_EN, 0);
		rtc_write_sync_lp(data);
		regmap_write(data->regmap, data->offset + SNVS_LPTAR, time);

		/* Clear alarm interrupt status bit */

Admin message