Commit 7baeb6a5 authored May 16, 2005 by Peter Osterlund Committed by Linus Torvalds May 17, 2005

[PATCH] CDRW/DVD packet writing data corruption fix



I found a bug in the packet writing driver that could cause data
corruption.  The problem arised if the driver got a write request for a
sector in a "zone" it was already working on.  In that case it was supposed
to queue the write request until it was done processing earlier requests
for the same zone, and instead work on some other zone in the mean time.
However, if there was no other zone to work on, the driver would initiate
two packet_data objects for the same zone, causing unpredictable things to
happen.

Signed-off-by: Peter Osterlund <petero2@telia.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent d0856009

drivers/block/pktcdvd.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -914,9 +914,11 @@ static int pkt_handle_queue(struct pktcdvd_device *pd)
		bio = node->bio;
		zone = ZONE(bio->bi_sector, pd);
		list_for_each_entry(p, &pd->cdrw.pkt_active_list, list) {
		if (p->sector == zone)
		if (p->sector == zone) {
		bio = NULL;
		goto try_next_bio;
		}
		}
		break;
		try_next_bio:
		node = pkt_rbtree_next(node);

Admin message