Commit 7ba96680 authored Dec 09, 2011 by Peter Ujfalusi Committed by Tony Lindgren Dec 09, 2011

ARM: OMAP2+: DMA: Workaround for invalid source position



If the DMA source position has been asked before the
first actual data transfer has been done, the CSAC
register does not contain valid information.
We can identify this situation by checking the CDAC
register:
CDAC != 0 indicates that the DMA transfer on the channel has
been started already.
When CDAC == 0 we can not trust the CSAC value since it has
not been updated, and can contain random number.
Return the start address in case the DMA has not jet started.

Note: The CDAC register has been initialized to 0 at dma_start
time.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 5611cc45

arch/arm/plat-omap/dma.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -1034,6 +1034,18 @@ dma_addr_t omap_get_dma_src_pos(int lch)
		if (IS_DMA_ERRATA(DMA_ERRATA_3_3) && offset == 0)
		offset = p->dma_read(CSAC, lch);

		if (!cpu_is_omap15xx()) {
		/*
		* CDAC == 0 indicates that the DMA transfer on the channel has
		* not been started (no data has been transferred so far).
		* Return the programmed source start address in this case.
		*/
		if (likely(p->dma_read(CDAC, lch)))
		offset = p->dma_read(CSAC, lch);
		else
		offset = p->dma_read(CSSA, lch);
		}

		if (cpu_class_is_omap1())
		offset \|= (p->dma_read(CSSA, lch) & 0xFFFF0000);

Admin message