Commit 7ba7319f authored Mar 20, 2019 by Joel Fernandes (Google) Committed by Ingo Molnar Apr 03, 2019

sched/core: Annotate perf_domain pointer with __rcu



This fixes the following sparse errors in sched/fair.c:

  fair.c:6506:14: error: incompatible types in comparison expression
  fair.c:8642:21: error: incompatible types in comparison expression

Using __rcu will also help sparse catch any future bugs.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
[ From an RCU perspective. ]
Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: keescook@chromium.org
Cc: kernel-hardening@lists.openwall.com
Cc: kernel-team@android.com
Link: https://lkml.kernel.org/r/20190321003426.160260-5-joel@joelfernandes.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 03f4b48e

kernel/sched/sched.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -780,7 +780,7 @@ struct root_domain {
	* NULL-terminated list of performance domains intersecting with the		* NULL-terminated list of performance domains intersecting with the
	* CPUs of the rd. Protected by RCU.		* CPUs of the rd. Protected by RCU.
	*/		*/
	struct perf_domain *pd;		struct perf_domain __rcu *pd;
	};		};

	extern struct root_domain def_root_domain;		extern struct root_domain def_root_domain;

Admin message