Commit 7b93ca43 authored Nov 11, 2016 by Ondrej Zary Committed by Martin K. Petersen Nov 12, 2016

scsi: g_NCR5380: Fix release_region in error handling



When a SW-configurable card is specified but not found, the driver
releases wrong region, causing the following message in kernel log:
Trying to free nonexistent resource <0000000000000000-000000000000000f>

Fix it by assigning base earlier.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Fixes: a8cfbcae ("scsi: g_NCR5380: Stop using scsi_module.c")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ee32c909

drivers/scsi/g_NCR5380.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -164,12 +164,12 @@ static int generic_NCR5380_init_one(struct scsi_host_template *tpnt,
		if (ports[i]) {
		/* At this point we have our region reserved */
		magic_configure(i, 0, magic); /* no IRQ yet */
		outb(0xc0, ports[i] + 9);
		if (inb(ports[i] + 9) != 0x80) {
		base = ports[i];
		outb(0xc0, base + 9);
		if (inb(base + 9) != 0x80) {
		ret = -ENODEV;
		goto out_release;
		}
		base = ports[i];
		port_idx = i;
		} else
		return -EINVAL;

Admin message