Commit 7b919a53 authored by Tommi Rantala's avatar Tommi Rantala Committed by Arnaldo Carvalho de Melo
Browse files

perf bench: Clear struct sigaction before sigaction() syscall 



Avoid garbage in sigaction structs used in sigaction() syscalls.
Valgrind is complaining about it.

Signed-off-by: default avatarTommi Rantala <tommi.t.rantala@nokia.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Changbin Du <changbin.du@intel.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lore.kernel.org/lkml/20200305083714.9381-4-tommi.t.rantala@nokia.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent f649bd9d

tools/perf/bench/epoll-ctl.c

+1 −0
Original line number Diff line number Diff line
@@ -312,6 +312,7 @@ int bench_epoll_ctl(int argc, const char **argv) 
		exit(EXIT_FAILURE);

	}



	memset(&act, 0, sizeof(act));

	sigfillset(&act.sa_mask);

	act.sa_sigaction = toggle_done;

	sigaction(SIGINT, &act, NULL);

tools/perf/bench/epoll-wait.c

+1 −0
Original line number Diff line number Diff line
@@ -426,6 +426,7 @@ int bench_epoll_wait(int argc, const char **argv) 
		exit(EXIT_FAILURE);

	}



	memset(&act, 0, sizeof(act));

	sigfillset(&act.sa_mask);

	act.sa_sigaction = toggle_done;

	sigaction(SIGINT, &act, NULL);

tools/perf/bench/futex-hash.c

+1 −0
Original line number Diff line number Diff line
@@ -137,6 +137,7 @@ int bench_futex_hash(int argc, const char **argv) 
	if (!cpu)

		goto errmem;



	memset(&act, 0, sizeof(act));

	sigfillset(&act.sa_mask);

	act.sa_sigaction = toggle_done;

	sigaction(SIGINT, &act, NULL);

tools/perf/bench/futex-lock-pi.c

+1 −0
Original line number Diff line number Diff line
@@ -160,6 +160,7 @@ int bench_futex_lock_pi(int argc, const char **argv) 
	if (!cpu)

		err(EXIT_FAILURE, "calloc");



	memset(&act, 0, sizeof(act));

	sigfillset(&act.sa_mask);

	act.sa_sigaction = toggle_done;

	sigaction(SIGINT, &act, NULL);

tools/perf/bench/futex-requeue.c

+1 −0
Original line number Diff line number Diff line
@@ -128,6 +128,7 @@ int bench_futex_requeue(int argc, const char **argv) 
	if (!cpu)

		err(EXIT_FAILURE, "cpu_map__new");



	memset(&act, 0, sizeof(act));

	sigfillset(&act.sa_mask);

	act.sa_sigaction = toggle_done;

	sigaction(SIGINT, &act, NULL);

CRA Git | Maintained and supported by SUSTech CRA and CCSE