Commit 7b7b1ace authored by Al Viro's avatar Al Viro Committed by Linus Torvalds
Browse files

[PATCH] saner handling of auto_acct_off() and DQUOT_OFF() in umount 



The way we currently deal with quota and process accounting that might
keep vfsmount busy at umount time is inherently broken; we try to turn
them off just in case (not quite correctly, at that) and

  a) pray umount doesn't fail (otherwise they'll stay turned off)
  b) pray nobody doesn anything funny just as we turn quota off

Moreover, LSM provides hooks for doing the same sort of broken logics.

The proper way to deal with that is to introduce the second kind of
reference to vfsmount.  Semantics:

 - when the last normal reference is dropped, all special ones are
   converted to normal ones and if there had been any, cleanup is done.
 - normal reference can be cloned into a special one
 - special reference can be converted to normal one; that's a no-op if
   we'd already passed the point of no return (i.e.  mntput() had
   converted special references to normal and started cleanup).

The way it works: e.g. starting process accounting converts the vfsmount
reference pinned by the opened file into special one and turns it back
to normal when it gets shut down; acct_auto_close() is done when no
normal references are left.  That way it does *not* obstruct umount(2)
and it silently gets turned off when the last normal reference to
vfsmount is gone.  Which is exactly what we want...

The same should be done by LSM module that holds some internal
references to vfsmount and wants to shut them down on umount - it should
make them special and security_sb_umount_close() will be called exactly
when the last normal reference to vfsmount is gone.

quota handling is even simpler - we don't use normal file IO anymore, so
there's no need to hold vfsmounts at all.  DQUOT_OFF() is done from
deactivate_super(), where it really belongs.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 254ce8dc

fs/dquot.c

+2 −16
Original line number Diff line number Diff line
@@ -1321,13 +1321,11 @@ int vfs_quota_off(struct super_block *sb, int type) 
	int cnt;

	struct quota_info *dqopt = sb_dqopt(sb);

	struct inode *toputinode[MAXQUOTAS];

	struct vfsmount *toputmnt[MAXQUOTAS];



	/* We need to serialize quota_off() for device */

	down(&dqopt->dqonoff_sem);

	for (cnt = 0; cnt < MAXQUOTAS; cnt++) {

		toputinode[cnt] = NULL;

		toputmnt[cnt] = NULL;

		if (type != -1 && cnt != type)

			continue;

		if (!sb_has_quota_enabled(sb, cnt))
@@ -1348,9 +1346,7 @@ int vfs_quota_off(struct super_block *sb, int type) 
		put_quota_format(dqopt->info[cnt].dqi_format);



		toputinode[cnt] = dqopt->files[cnt];

		toputmnt[cnt] = dqopt->mnt[cnt];

		dqopt->files[cnt] = NULL;

		dqopt->mnt[cnt] = NULL;

		dqopt->info[cnt].dqi_flags = 0;

		dqopt->info[cnt].dqi_igrace = 0;

		dqopt->info[cnt].dqi_bgrace = 0;
@@ -1358,10 +1354,7 @@ int vfs_quota_off(struct super_block *sb, int type) 
	}

	up(&dqopt->dqonoff_sem);

	/* Sync the superblock so that buffers with quota data are written to

	 * disk (and so userspace sees correct data afterwards).

	 * The reference to vfsmnt we are still holding protects us from

	 * umount (we don't have it only when quotas are turned on/off for

	 * journal replay but in that case we are guarded by the fs anyway). */

	 * disk (and so userspace sees correct data afterwards). */

	if (sb->s_op->sync_fs)

		sb->s_op->sync_fs(sb, 1);

	sync_blockdev(sb->s_bdev);
@@ -1385,10 +1378,6 @@ int vfs_quota_off(struct super_block *sb, int type) 
				iput(toputinode[cnt]);

			}

			up(&dqopt->dqonoff_sem);

			/* We don't hold the reference when we turned on quotas

			 * just for the journal replay... */

			if (toputmnt[cnt])

				mntput(toputmnt[cnt]);

		}

	if (sb->s_bdev)

		invalidate_bdev(sb->s_bdev, 0);
@@ -1503,11 +1492,8 @@ int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path) 
	/* Quota file not on the same filesystem? */

	if (nd.mnt->mnt_sb != sb)

		error = -EXDEV;

	else {

	else

		error = vfs_quota_on_inode(nd.dentry->d_inode, type, format_id);

		if (!error)

			sb_dqopt(sb)->mnt[type] = mntget(nd.mnt);

	}

out_path:

	path_release(&nd);

	return error;

fs/namespace.c

+41 −23
Original line number Diff line number Diff line
@@ -172,7 +172,7 @@ clone_mnt(struct vfsmount *old, struct dentry *root) 
	return mnt;

}



void __mntput(struct vfsmount *mnt)

static inline void __mntput(struct vfsmount *mnt)

{

	struct super_block *sb = mnt->mnt_sb;

	dput(mnt->mnt_root);
@@ -180,7 +180,46 @@ void __mntput(struct vfsmount *mnt) 
	deactivate_super(sb);

}



EXPORT_SYMBOL(__mntput);

void mntput_no_expire(struct vfsmount *mnt)

{

repeat:

	if (atomic_dec_and_lock(&mnt->mnt_count, &vfsmount_lock)) {

		if (likely(!mnt->mnt_pinned)) {

			spin_unlock(&vfsmount_lock);

			__mntput(mnt);

			return;

		}

		atomic_add(mnt->mnt_pinned + 1, &mnt->mnt_count);

		mnt->mnt_pinned = 0;

		spin_unlock(&vfsmount_lock);

		acct_auto_close_mnt(mnt);

		security_sb_umount_close(mnt);

		goto repeat;

	}

}



EXPORT_SYMBOL(mntput_no_expire);



void mnt_pin(struct vfsmount *mnt)

{

	spin_lock(&vfsmount_lock);

	mnt->mnt_pinned++;

	spin_unlock(&vfsmount_lock);

}



EXPORT_SYMBOL(mnt_pin);



void mnt_unpin(struct vfsmount *mnt)

{

	spin_lock(&vfsmount_lock);

	if (mnt->mnt_pinned) {

		atomic_inc(&mnt->mnt_count);

		mnt->mnt_pinned--;

	}

	spin_unlock(&vfsmount_lock);

}



EXPORT_SYMBOL(mnt_unpin);



/* iterator */

static void *m_start(struct seq_file *m, loff_t *pos)
@@ -435,16 +474,6 @@ static int do_umount(struct vfsmount *mnt, int flags) 
	down_write(&current->namespace->sem);

	spin_lock(&vfsmount_lock);



	if (atomic_read(&sb->s_active) == 1) {

		/* last instance - try to be smart */

		spin_unlock(&vfsmount_lock);

		lock_kernel();

		DQUOT_OFF(sb);

		acct_auto_close(sb);

		unlock_kernel();

		security_sb_umount_close(mnt);

		spin_lock(&vfsmount_lock);

	}

	retval = -EBUSY;

	if (atomic_read(&mnt->mnt_count) == 2 || flags & MNT_DETACH) {

		if (!list_empty(&mnt->mnt_list))
@@ -850,17 +879,6 @@ static void expire_mount(struct vfsmount *mnt, struct list_head *mounts) 
		detach_mnt(mnt, &old_nd);

		spin_unlock(&vfsmount_lock);

		path_release(&old_nd);



		/*

		 * Now lay it to rest if this was the last ref on the superblock

		 */

		if (atomic_read(&mnt->mnt_sb->s_active) == 1) {

			/* last instance - try to be smart */

			lock_kernel();

			DQUOT_OFF(mnt->mnt_sb);

			acct_auto_close(mnt->mnt_sb);

			unlock_kernel();

		}

		mntput(mnt);

	} else {

		/*

fs/super.c

+1 −0
Original line number Diff line number Diff line
@@ -171,6 +171,7 @@ void deactivate_super(struct super_block *s) 
	if (atomic_dec_and_lock(&s->s_active, &sb_lock)) {

		s->s_count -= S_BIAS-1;

		spin_unlock(&sb_lock);

		DQUOT_OFF(s);

		down_write(&s->s_umount);

		fs->kill_sb(s);

		put_filesystem(fs);

include/linux/acct.h

+3 −0
Original line number Diff line number Diff line
@@ -117,12 +117,15 @@ struct acct_v3 
#include <linux/config.h>



#ifdef CONFIG_BSD_PROCESS_ACCT

struct vfsmount;

struct super_block;

extern void acct_auto_close_mnt(struct vfsmount *m);

extern void acct_auto_close(struct super_block *sb);

extern void acct_process(long exitcode);

extern void acct_update_integrals(struct task_struct *tsk);

extern void acct_clear_integrals(struct task_struct *tsk);

#else

#define acct_auto_close_mnt(x)	do { } while (0)

#define acct_auto_close(x)	do { } while (0)

#define acct_process(x)		do { } while (0)

#define acct_update_integrals(x)		do { } while (0)

include/linux/mount.h

+4 −9
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ struct vfsmount 
	struct list_head mnt_list;

	struct list_head mnt_expire;	/* link in fs-specific expiry list */

	struct namespace *mnt_namespace; /* containing namespace */

	int mnt_pinned;

};



static inline struct vfsmount *mntget(struct vfsmount *mnt)
@@ -46,15 +47,9 @@ static inline struct vfsmount *mntget(struct vfsmount *mnt) 
	return mnt;

}



extern void __mntput(struct vfsmount *mnt);



static inline void mntput_no_expire(struct vfsmount *mnt)

{

	if (mnt) {

		if (atomic_dec_and_test(&mnt->mnt_count))

			__mntput(mnt);

	}

}

extern void mntput_no_expire(struct vfsmount *mnt);

extern void mnt_pin(struct vfsmount *mnt);

extern void mnt_unpin(struct vfsmount *mnt);



static inline void mntput(struct vfsmount *mnt)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE