Commit 7b7b0b90 authored Jul 25, 2010 by Dan Carpenter Committed by David S. Miller Jul 26, 2010

caif: handle snprintf() return



snprintf() returns the number of bytes that would have been written.  It
can be larger than the size of the buffer.  The current code won't
overflow, but people cut and paste this stuff so lets do it right and
also make the static checkers happy.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 652c6717

drivers/net/caif/caif_spi.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -165,6 +165,9 @@ static ssize_t dbgfs_state(struct file file, char __user user_buf,
		len += snprintf((buf + len), (DEBUGFS_BUF_SIZE - len),
		"Next RX len: %d\n", cfspi->rx_npck_len);

		if (len > DEBUGFS_BUF_SIZE)
		len = DEBUGFS_BUF_SIZE;

		size = simple_read_from_buffer(user_buf, count, ppos, buf, len);
		kfree(buf);

Admin message