Commit 7b668ebe authored by Takashi Iwai's avatar Takashi Iwai Committed by Dave Airlie
Browse files

drm: edid: Don't add inferred modes with higher resolution 



When a monitor EDID doesn't give the preferred bit, driver assumes
that the mode with the higest resolution and rate is the preferred
mode.  Meanwhile the recent changes for allowing more modes in the
GFT/CVT ranges give actually more modes, and some modes may be over
the native size.  Thus such a mode would be picked up as the preferred
mode although it's no native resolution.

For avoiding such a problem, this patch limits the addition of
inferred modes by checking not to be greater than other modes.
Also, it checks the duplicated mode entry at the same time.

Reviewed-by: default avatarAdam Jackson <ajax@redhat.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 1ef5325b

drivers/gpu/drm/drm_edid.c

+24 −3
Original line number Diff line number Diff line
@@ -1039,6 +1039,24 @@ mode_in_range(const struct drm_display_mode *mode, struct edid *edid, 
	return true;

}



static bool valid_inferred_mode(const struct drm_connector *connector,

				const struct drm_display_mode *mode)

{

	struct drm_display_mode *m;

	bool ok = false;



	list_for_each_entry(m, &connector->probed_modes, head) {

		if (mode->hdisplay == m->hdisplay &&

		    mode->vdisplay == m->vdisplay &&

		    drm_mode_vrefresh(mode) == drm_mode_vrefresh(m))

			return false; /* duplicated */

		if (mode->hdisplay <= m->hdisplay &&

		    mode->vdisplay <= m->vdisplay)

			ok = true;

	}

	return ok;

}



static int

drm_dmt_modes_for_range(struct drm_connector *connector, struct edid *edid,

			struct detailed_timing *timing)
@@ -1048,7 +1066,8 @@ drm_dmt_modes_for_range(struct drm_connector *connector, struct edid *edid, 
	struct drm_device *dev = connector->dev;



	for (i = 0; i < drm_num_dmt_modes; i++) {

		if (mode_in_range(drm_dmt_modes + i, edid, timing)) {

		if (mode_in_range(drm_dmt_modes + i, edid, timing) &&

		    valid_inferred_mode(connector, drm_dmt_modes + i)) {

			newmode = drm_mode_duplicate(dev, &drm_dmt_modes[i]);

			if (newmode) {

				drm_mode_probed_add(connector, newmode);
@@ -1088,7 +1107,8 @@ drm_gtf_modes_for_range(struct drm_connector *connector, struct edid *edid, 
			return modes;



		fixup_mode_1366x768(newmode);

		if (!mode_in_range(newmode, edid, timing)) {

		if (!mode_in_range(newmode, edid, timing) ||

		    !valid_inferred_mode(connector, newmode)) {

			drm_mode_destroy(dev, newmode);

			continue;

		}
@@ -1116,7 +1136,8 @@ drm_cvt_modes_for_range(struct drm_connector *connector, struct edid *edid, 
			return modes;



		fixup_mode_1366x768(newmode);

		if (!mode_in_range(newmode, edid, timing)) {

		if (!mode_in_range(newmode, edid, timing) ||

		    !valid_inferred_mode(connector, newmode)) {

			drm_mode_destroy(dev, newmode);

			continue;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE