Commit 7b62d31d authored Oct 02, 2020 by Coly Li Committed by David S. Miller Oct 02, 2020

net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send



If a page sent into kernel_sendpage() is a slab page or it doesn't have
ref_count, this page is improper to send by the zero copy sendpage()
method. Otherwise such page might be unexpected released in network code
path and causes impredictable panic due to kernel memory management data
structure corruption.

This path adds a WARN_ON() on the sending page before sends it into the
concrete zero-copy sendpage() method, if the page is improper for the
zero-copy sendpage() method, a warning message can be observed before
the consequential unpredictable kernel panic.

This patch does not change existing kernel_sendpage() behavior for the
improper page zero-copy send, it just provides hint warning message for
following potential panic due the kernel memory heap corruption.

Signed-off-by: Coly Li <colyli@suse.de>
Cc: Cong Wang <amwang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c381b079

net/socket.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -3638,9 +3638,11 @@ EXPORT_SYMBOL(kernel_getpeername);
		int kernel_sendpage(struct socket sock, struct page page, int offset,
		size_t size, int flags)
		{
		if (sock->ops->sendpage)
		if (sock->ops->sendpage) {
		/* Warn in case the improper page to zero-copy send */
		WARN_ONCE(!sendpage_ok(page), "improper page for zero-copy send");
		return sock->ops->sendpage(sock, page, offset, size, flags);

		}
		return sock_no_sendpage(sock, page, offset, size, flags);
		}
		EXPORT_SYMBOL(kernel_sendpage);

Admin message