Unverified Commit 7b51f3c7 authored by Samuel Holland's avatar Samuel Holland Committed by Mark Brown
Browse files

ASoC: sun8i-codec: Consistently name DAPM widgets and routes 



This cleans up the mixer widget names. The AIF1 AD0 Mixer names were
previously wrong -- they do not control the digital side of the ADC. The
DAC mixer widgets were not wrong, but they were verbose and did not
match the naming scheme of the other widgets.

The mixer controls are not renamed because they are exposed to
userspace.

Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20201001021148.15852-5-samuel@sholland.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d58b7247

sound/soc/sunxi/sun8i-codec.c

+16 −16
Original line number Diff line number Diff line
@@ -418,9 +418,9 @@ static const struct snd_soc_dapm_widget sun8i_codec_dapm_widgets[] = { 
			    SUN8I_AIF1_ADCDAT_CTRL_AIF1_AD0R_ENA, 0),



	/* AIF "ADC" Mixers */

	SOC_MIXER_ARRAY("Left Digital ADC Mixer", SND_SOC_NOPM, 0, 0,

	SOC_MIXER_ARRAY("AIF1 AD0L Mixer", SND_SOC_NOPM, 0, 0,

			sun8i_aif1_ad0_mixer_controls),

	SOC_MIXER_ARRAY("Right Digital ADC Mixer", SND_SOC_NOPM, 0, 0,

	SOC_MIXER_ARRAY("AIF1 AD0R Mixer", SND_SOC_NOPM, 0, 0,

			sun8i_aif1_ad0_mixer_controls),



	/* AIF "DAC" Inputs */
@@ -440,9 +440,9 @@ static const struct snd_soc_dapm_widget sun8i_codec_dapm_widgets[] = { 
	SND_SOC_DAPM_DAC("DACR", NULL, SND_SOC_NOPM, 0, 0),



	/* DAC Mixers */

	SOC_MIXER_ARRAY("Left Digital DAC Mixer", SND_SOC_NOPM, 0, 0,

	SOC_MIXER_ARRAY("DACL Mixer", SND_SOC_NOPM, 0, 0,

			sun8i_dac_mixer_controls),

	SOC_MIXER_ARRAY("Right Digital DAC Mixer", SND_SOC_NOPM, 0, 0,

	SOC_MIXER_ARRAY("DACR Mixer", SND_SOC_NOPM, 0, 0,

			sun8i_dac_mixer_controls),

};
@@ -473,26 +473,26 @@ static const struct snd_soc_dapm_route sun8i_codec_dapm_routes[] = { 
	{ "DACR", NULL, "DAC" },



	/* AIF "ADC" Output Routes */

	{ "AIF1 AD0L", NULL, "Left Digital ADC Mixer" },

	{ "AIF1 AD0R", NULL, "Right Digital ADC Mixer" },

	{ "AIF1 AD0L", NULL, "AIF1 AD0L Mixer" },

	{ "AIF1 AD0R", NULL, "AIF1 AD0R Mixer" },



	/* AIF "ADC" Mixer Routes */

	{ "Left Digital ADC Mixer", "AIF1 Slot 0 Digital ADC Capture Switch", "AIF1 DA0L" },

	{ "Left Digital ADC Mixer", "AIF1 Data Digital ADC Capture Switch", "ADCL" },

	{ "AIF1 AD0L Mixer", "AIF1 Slot 0 Digital ADC Capture Switch", "AIF1 DA0L" },

	{ "AIF1 AD0L Mixer", "AIF1 Data Digital ADC Capture Switch", "ADCL" },



	{ "Right Digital ADC Mixer", "AIF1 Slot 0 Digital ADC Capture Switch", "AIF1 DA0R" },

	{ "Right Digital ADC Mixer", "AIF1 Data Digital ADC Capture Switch", "ADCR" },

	{ "AIF1 AD0R Mixer", "AIF1 Slot 0 Digital ADC Capture Switch", "AIF1 DA0R" },

	{ "AIF1 AD0R Mixer", "AIF1 Data Digital ADC Capture Switch", "ADCR" },



	/* DAC Output Routes */

	{ "DACL", NULL, "Left Digital DAC Mixer" },

	{ "DACR", NULL, "Right Digital DAC Mixer" },

	{ "DACL", NULL, "DACL Mixer" },

	{ "DACR", NULL, "DACR Mixer" },



	/* DAC Mixer Routes */

	{ "Left Digital DAC Mixer", "AIF1 Slot 0 Digital DAC Playback Switch", "AIF1 DA0L" },

	{ "Left Digital DAC Mixer", "ADC Digital DAC Playback Switch", "ADCL" },

	{ "DACL Mixer", "AIF1 Slot 0 Digital DAC Playback Switch", "AIF1 DA0L" },

	{ "DACL Mixer", "ADC Digital DAC Playback Switch", "ADCL" },



	{ "Right Digital DAC Mixer", "AIF1 Slot 0 Digital DAC Playback Switch", "AIF1 DA0R" },

	{ "Right Digital DAC Mixer", "ADC Digital DAC Playback Switch", "ADCR" },

	{ "DACR Mixer", "AIF1 Slot 0 Digital DAC Playback Switch", "AIF1 DA0R" },

	{ "DACR Mixer", "ADC Digital DAC Playback Switch", "ADCR" },

};



static const struct snd_soc_dapm_widget sun8i_codec_legacy_widgets[] = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE