Commit 7b3d9545 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Revert "scsi: revert "[SCSI] Get rid of scsi_cmnd->done"" 



This reverts commit ac40532e, which gets
us back the original cleanup of 6f5391c2.

It turns out that the bug that was triggered by that commit was
apparently not actually triggered by that commit at all, and just the
testing conditions had changed enough to make it appear to be due to it.

The real problem seems to have been found by Peter Osterlund:

  "pktcdvd sets it [block device size] when opening the /dev/pktcdvd
   device, but when the drive is later opened as /dev/scd0, there is
   nothing that sets it back.  (Btw, 40944 is possible if the disk is a
   CDRW that was formatted with "cdrwtool -m 10236".)

   The problem is that pktcdvd opens the cd device in non-blocking mode
   when pktsetup is run, and doesn't close it again until pktsetup -d is
   run.  The effect is that if you meanwhile open the cd device,
   blkdev.c:do_open() doesn't call bd_set_size() because
   bdev->bd_openers is non-zero."

In particular, to repeat the bug (regardless of whether commit
6f5391c2 is applied or not):

  " 1. Start with an empty drive.
    2. pktsetup 0 /dev/scd0
    3. Insert a CD containing an isofs filesystem.
    4. mount /dev/pktcdvd/0 /mnt/tmp
    5. umount /mnt/tmp
    6. Press the eject button.
    7. Insert a DVD containing a non-writable filesystem.
    8. mount /dev/scd0 /mnt/tmp
    9. find /mnt/tmp -type f -print0 | xargs -0 sha1sum >/dev/null
    10. If the DVD contains data beyond the physical size of a CD, you
        get I/O errors in the terminal, and dmesg reports lots of
        "attempt to access beyond end of device" errors."

which in turn is because the nested open after the media change won't
cause the size to be set properly (because the original open still holds
the block device, and we only do the bd_set_size() when we don't have
other people holding the device open).

The proper fix for that is probably to just do something like

	bdev->bd_inode->i_size = (loff_t)get_capacity(disk)<<9;

in fs/block_dev.c:do_open() even for the cases where we're not the
original opener (but *not* call bd_set_size(), since that will also
change the block size of the device).

Cc: Peter Osterlund <petero2@telia.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 91183344

drivers/scsi/scsi.c

+17 −3
Original line number Diff line number Diff line
@@ -59,6 +59,7 @@ 
#include <scsi/scsi_cmnd.h>

#include <scsi/scsi_dbg.h>

#include <scsi/scsi_device.h>

#include <scsi/scsi_driver.h>

#include <scsi/scsi_eh.h>

#include <scsi/scsi_host.h>

#include <scsi/scsi_tcq.h>
@@ -367,9 +368,8 @@ void scsi_log_send(struct scsi_cmnd *cmd) 
			scsi_print_command(cmd);

			if (level > 3) {

				printk(KERN_INFO "buffer = 0x%p, bufflen = %d,"

				       " done = 0x%p, queuecommand 0x%p\n",

				       " queuecommand 0x%p\n",

					scsi_sglist(cmd), scsi_bufflen(cmd),

					cmd->done,

					cmd->device->host->hostt->queuecommand);



			}
@@ -654,6 +654,12 @@ void __scsi_done(struct scsi_cmnd *cmd) 
	blk_complete_request(rq);

}



/* Move this to a header if it becomes more generally useful */

static struct scsi_driver *scsi_cmd_to_driver(struct scsi_cmnd *cmd)

{

	return *(struct scsi_driver **)cmd->request->rq_disk->private_data;

}



/*

 * Function:    scsi_finish_command

 *
@@ -665,6 +671,8 @@ void scsi_finish_command(struct scsi_cmnd *cmd) 
{

	struct scsi_device *sdev = cmd->device;

	struct Scsi_Host *shost = sdev->host;

	struct scsi_driver *drv;

	unsigned int good_bytes;



	scsi_device_unbusy(sdev);
@@ -690,7 +698,13 @@ void scsi_finish_command(struct scsi_cmnd *cmd) 
				"Notifying upper driver of completion "

				"(result %x)\n", cmd->result));



	cmd->done(cmd);

	good_bytes = cmd->request_bufflen;

        if (cmd->request->cmd_type != REQ_TYPE_BLOCK_PC) {

		drv = scsi_cmd_to_driver(cmd);

		if (drv->done)

			good_bytes = drv->done(cmd);

	}

	scsi_io_completion(cmd, good_bytes);

}

EXPORT_SYMBOL(scsi_finish_command);

drivers/scsi/scsi_error.c

+0 −1
Original line number Diff line number Diff line
@@ -1699,7 +1699,6 @@ scsi_reset_provider(struct scsi_device *dev, int flag) 
	memset(&scmd->cmnd, '\0', sizeof(scmd->cmnd));

    

	scmd->scsi_done		= scsi_reset_provider_done_command;

	scmd->done			= NULL;

	scmd->request_buffer		= NULL;

	scmd->request_bufflen		= 0;

drivers/scsi/scsi_lib.c

+0 −14
Original line number Diff line number Diff line
@@ -1092,7 +1092,6 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes) 
	}

	scsi_end_request(cmd, 0, this_count, !result);

}

EXPORT_SYMBOL(scsi_io_completion);



/*

 * Function:    scsi_init_io()
@@ -1171,18 +1170,6 @@ static struct scsi_cmnd *scsi_get_cmd_from_req(struct scsi_device *sdev, 
	return cmd;

}



static void scsi_blk_pc_done(struct scsi_cmnd *cmd)

{

	BUG_ON(!blk_pc_request(cmd->request));

	/*

	 * This will complete the whole command with uptodate=1 so

	 * as far as the block layer is concerned the command completed

	 * successfully. Since this is a REQ_BLOCK_PC command the

	 * caller should check the request's errors value

	 */

	scsi_io_completion(cmd, cmd->request_bufflen);

}



int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req)

{

	struct scsi_cmnd *cmd;
@@ -1232,7 +1219,6 @@ int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req) 
	cmd->transfersize = req->data_len;

	cmd->allowed = req->retries;

	cmd->timeout_per_command = req->timeout;

	cmd->done = scsi_blk_pc_done;

	return BLKPREP_OK;

}

EXPORT_SYMBOL(scsi_setup_blk_pc_cmnd);

drivers/scsi/scsi_priv.h

+1 −0
Original line number Diff line number Diff line
@@ -68,6 +68,7 @@ extern int scsi_maybe_unblock_host(struct scsi_device *sdev); 
extern void scsi_device_unbusy(struct scsi_device *sdev);

extern int scsi_queue_insert(struct scsi_cmnd *cmd, int reason);

extern void scsi_next_command(struct scsi_cmnd *cmd);

extern void scsi_io_completion(struct scsi_cmnd *, unsigned int);

extern void scsi_run_host_queues(struct Scsi_Host *shost);

extern struct request_queue *scsi_alloc_queue(struct scsi_device *sdev);

extern void scsi_free_queue(struct request_queue *q);

drivers/scsi/sd.c

+18 −10
Original line number Diff line number Diff line
@@ -86,6 +86,19 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK); 
MODULE_ALIAS_SCSI_DEVICE(TYPE_MOD);

MODULE_ALIAS_SCSI_DEVICE(TYPE_RBC);



static int  sd_revalidate_disk(struct gendisk *);

static int  sd_probe(struct device *);

static int  sd_remove(struct device *);

static void sd_shutdown(struct device *);

static int sd_suspend(struct device *, pm_message_t state);

static int sd_resume(struct device *);

static void sd_rescan(struct device *);

static int sd_done(struct scsi_cmnd *);

static void sd_read_capacity(struct scsi_disk *sdkp, unsigned char *buffer);

static void scsi_disk_release(struct class_device *cdev);

static void sd_print_sense_hdr(struct scsi_disk *, struct scsi_sense_hdr *);

static void sd_print_result(struct scsi_disk *, int);



static DEFINE_IDR(sd_index_idr);

static DEFINE_SPINLOCK(sd_index_lock);
@@ -240,6 +253,7 @@ static struct scsi_driver sd_template = { 
		.shutdown	= sd_shutdown,

	},

	.rescan			= sd_rescan,

	.done			= sd_done,

};



/*
@@ -508,12 +522,6 @@ static int sd_prep_fn(struct request_queue *q, struct request *rq) 
	SCpnt->allowed = SD_MAX_RETRIES;

	SCpnt->timeout_per_command = timeout;



	/*

	 * This is the completion routine we use.  This is matched in terms

	 * of capability to this function.

	 */

	SCpnt->done = sd_rw_intr;



	/*

	 * This indicates that the command is ready from our end to be

	 * queued.
@@ -887,13 +895,13 @@ static struct block_device_operations sd_fops = { 
};



/**

 *	sd_rw_intr - bottom half handler: called when the lower level

 *	sd_done - bottom half handler: called when the lower level

 *	driver has completed (successfully or otherwise) a scsi command.

 *	@SCpnt: mid-level's per command structure.

 *

 *	Note: potentially run from within an ISR. Must not block.

 **/

static void sd_rw_intr(struct scsi_cmnd * SCpnt)

static int sd_done(struct scsi_cmnd *SCpnt)

{

	int result = SCpnt->result;

 	unsigned int xfer_size = SCpnt->request_bufflen;
@@ -914,7 +922,7 @@ static void sd_rw_intr(struct scsi_cmnd * SCpnt) 
	SCSI_LOG_HLCOMPLETE(1, scsi_print_result(SCpnt));

	if (sense_valid) {

		SCSI_LOG_HLCOMPLETE(1, scmd_printk(KERN_INFO, SCpnt,

						   "sd_rw_intr: sb[respc,sk,asc,"

						   "sd_done: sb[respc,sk,asc,"

						   "ascq]=%x,%x,%x,%x\n",

						   sshdr.response_code,

						   sshdr.sense_key, sshdr.asc,
@@ -986,7 +994,7 @@ static void sd_rw_intr(struct scsi_cmnd * SCpnt) 
		break;

	}

 out:

	scsi_io_completion(SCpnt, good_bytes);

	return good_bytes;

}



static int media_not_present(struct scsi_disk *sdkp,

CRA Git | Maintained and supported by SUSTech CRA and CCSE